update API url to Microsoft - #222
Open
antoinemineau wants to merge 1 commit into
Open
Conversation
hajekj
reviewed
May 22, 2025
| $url = $ref; | ||
| } else { | ||
| if (false !== strpos($this->urlAPI, 'graph.windows.net')) { | ||
| if (false !== strpos($this->urlAPI, 'graph.microsoft.com')) { |
Member
There was a problem hiding this comment.
I would prefer if this entire condition got removed from the code. Afaik Microsoft Graph doesn't support URLs like https://graph.microsoft.com/v1.0/<guid>/me etc. This was for Windows Azure Graph eg. https://learn.microsoft.com/en-us/graph/migrate-azure-ad-graph-request-differences#basic-requests
Other than that, it's great, once you update this, we can get it merged! Thanks for the PR!
|
Hi @antoinemineau, will you submit the changes requested by maintainers or did you find another workaround? |
I mentioned another possible solution? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I updated the code to use the new API url https://graph.microsoft.com/
It should fix those issues :
#216
#221