Simplified and cleaned up API and implementations#230
Merged
Conversation
Simplified the codebase by removing redundant null-safety declarations. These annotations are now applied at the module level within `module-info.java`.
Unified method signatures across controllers and improved null-handling in `PermissionHolder` operations. Introduced `@Nullable` annotations for clearer API usage.
Updated method signatures in `EconomyServiceWrapper` and `EconomyController` to include `@Nullable` annotations for world parameters. Improved null-handling logic for enhanced API clarity and consistency.
Updated method signatures in `BankController`, `WrappedBank`, and `BankServiceWrapper` to include `@Nullable` annotations for world parameters. Simplified null-handling logic to ensure consistent behavior across the API.
Updated method signatures in `ChatController`, `ChatServiceWrapper`, and related providers to include `@Nullable` annotations for world parameters. Simplified null-handling logic to ensure consistency across the chat API. Removed redundant `@NullMarked` annotations for clarity.
Updated method signatures in `GroupController`, `GroupManagerGroupController`, and `LuckPermsGroupController` to include `@Nullable` annotations for world parameters. Streamlined null-handling logic across the group API for consistency and clarity. Removed redundant `@NullMarked` annotations.
Simplified codebase by removing unused `@NullMarked` annotations from API classes. Improved consistency by relying on module-level null-safety declarations.
Updated method signatures and equality checks across multiple providers to include `@Nullable` annotations. Converted `SuperPermsPermissionController` to a record for simplification and improved consistency.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.