-
Notifications
You must be signed in to change notification settings - Fork 14.5k
Testing Ruby with RSpec: Split apart Ruby's Connect Four assignment into 3 separate files #29665
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good. Just a couple small nits/typos to fix and then it'll be good to approve.
|
||
Before getting into any big projects, you should have some practice with writing tests in RSpec. Learning is best done through doing after all! There are a lot of tests to go through and you have to refer to multiple files, but make sure to not feel too overwhelmed. We're all in this together! | ||
|
||
For this section, you're first going to complete a lot of exercises involving test-writing, and then finally implementing tests into an old you've written. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For this section, you're first going to complete a lot of exercises involving test-writing, and then finally implementing tests into an old you've written. | |
For this section, you're first going to complete a lot of exercises involving test-writing, and then finally implementing tests into an old project you've written. |
Missing word here.
1. Use mocks/doubles to isolate methods to make sure that they're sending back the right outputs. | ||
|
||
</div> | ||
At this point, you've written tests for older projects of yours, and have completed a plethora of other test-writign assignments to familiarize yourself with RSpec. You're now ready to create a new project with TDD in mind! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
At this point, you've written tests for older projects of yours, and have completed a plethora of other test-writign assignments to familiarize yourself with RSpec. You're now ready to create a new project with TDD in mind! | |
At this point, you've written tests for older projects of yours, and have completed a plethora of other test-writing assignments to familiarize yourself with RSpec. You're now ready to create a new project with TDD in mind! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are also a few markdown lint issues you'll need to fix. If you have trouble figuring any of them out, just let me know.
One of these is related to the difference in requirements between "projects" and "lessons." The linter assumes that your practice_rspec.md
and revisiting_tictactoe.md
files are lesson files because they don't have a project_
prefix. This means they expect a lesson structure to the markdown.
You can resolve this error by adding prefixing those file names with project_
just like the connect four file is.
And on last comment: in the original issue, I mentioned there will have to be some steps taken to actually get the content on the site. Did you want to take that work on? No big deal if not, and we can get someone else to do it. |
Because
I found that the Connect Four section of the Ruby path was very overwhelming. I proposed to split it up to make it less overwhelming.
This PR
Issue
Closes #29632
Additional Information
Pull Request Requirements
location of change: brief description of change
format, e.g.Intro to HTML and CSS lesson: Fix link text
Because
section summarizes the reason for this PRThis PR
section has a bullet point list describing the changes in this PRIssue
section