Skip to content

Conversation

@JoshDevHub
Copy link
Contributor

@JoshDevHub JoshDevHub commented Jan 5, 2026

Because

The previous wording makes it seem as if the program data should be pulled from the DOM. This is almost always a bad idea. And while I'm not overly concerned with learners following best practices (especially at this stage of the curriculum), I also don't think the curriculum should be actively telling them to do something like this.

This PR

  • Updates the wording on the calculator display requirement to write functions that update the number data as the user clicks buttons on the calculator. The display should then update to reflect the number's value.

Issue

Closes #XXXXX

Additional Information

Pull Request Requirements

  • I have thoroughly read and understand The Odin Project curriculum contributing guide
  • The title of this PR follows the location of change: brief description of change format, e.g. Intro to HTML and CSS lesson: Fix link text
  • The Because section summarizes the reason for this PR
  • The This PR section has a bullet point list describing the changes in this PR
  • If this PR addresses an open issue, it is linked in the Issue section
  • If any lesson files are included in this PR, they have been previewed with the Markdown preview tool to ensure it is formatted correctly
  • If any lesson files are included in this PR, they follow the Layout Style Guide

@github-actions github-actions bot added the Content: Foundations Involves the Foundations content label Jan 5, 2026
This is intended to establish a more direct relationship between
how the user is manipulating the program's *data* when they click
the buttons, not manipulating the calculator's display. The
display should function as a reflection of the data.
@JoshDevHub JoshDevHub force-pushed the reword_calculator_display_requirements branch from 909becf to 79fccec Compare January 5, 2026 19:37
@JoshDevHub JoshDevHub merged commit 7730e83 into TheOdinProject:main Jan 6, 2026
2 checks passed
@JoshDevHub JoshDevHub deleted the reword_calculator_display_requirements branch January 6, 2026 21:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Content: Foundations Involves the Foundations content

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants