Feat: Points: Add more exclamations #650
Conversation
JustWaveThings
added
the
Status: Awaiting Response
|
I would like pop in a suggestion for 9001 to say
|
| return 'FIVE THOUSAND POINTS. Now go touch grass.'; | ||
| } | ||
| if (points === 10000) { | ||
| return 'You know there is a world outside the Discord right?'; |
There was a problem hiding this comment.
| return 'You know there is a world outside the Discord right?'; | |
| return 'Quarter of the way there, only 30000 to go!'; |
| @@ -91,6 +91,12 @@ function exclamation(points, isGoodQuestion) { | |||
| if (points === 4000) { | |||
| return '`//TODO: Implement Club 4000`'; | |||
| } | |||
| if (points === 5000) { | |||
| return 'FIVE THOUSAND POINTS. Now go touch grass.'; | |||
There was a problem hiding this comment.
| return 'FIVE THOUSAND POINTS. Now go touch grass.'; | |
| return 'FIVE THOUSAND POINTS, [HALF WAY THERE](https://youtu.be/lDK9QqIzhwk?t=93)' |
There was a problem hiding this comment.
Nit and also prevent the youtube embed from popping up? Or intentional?
| return 'FIVE THOUSAND POINTS. Now go touch grass.'; | |
| return 'FIVE THOUSAND POINTS, [WE'RE HALF WAY THERE!](<https://youtu.be/lDK9QqIzhwk?t=93>)' |
There was a problem hiding this comment.
I forgot all about the Youtube embed. Your version is better; I left out the "WE'RE", because its addressed to a singular person, but looking at it again I think I like it better with the WE'RE included
There was a problem hiding this comment.
That being said, why halfway there for 5k? Considering you may change 10k to quarter of the way there (makes sense for 40k)
If Bon Jovi should be anywhere, I'd say it needs to be 20 (and only 20)
There was a problem hiding this comment.
That being said, why halfway there for 5k? Considering you may change 10k to quarter of the way there (makes sense for 40k)
Because 10K is also a nice milestone, and tbh I'm counting on people forgetting what the 5K text was by the time they hit 10K
If Bon Jovi should be anywhere, I'd say it needs to be 20 (and only 20)
I thought about it, but I feel like that might enforce a feeling of 40 points as like a goal to reach (with the associated club-40), rather than something that should just happen as a result of making good contributions to the Discord.
There was a problem hiding this comment.
Fair on the point about 20. 5k being "halfway" (given the 10k message) still feels a little odd to me, though that's only my opinion and not blocking of course.
There was a problem hiding this comment.
Fair on the point about 20. 5k being "halfway" (given the 10k message) still feels a little odd to me, though that's only my opinion and not blocking of course.
I get that, and I partially agree, but what I'm basically hoping for is that at some point A someone will get to 5K, go huh that's true, another 5K and I'm up to the next order of the magnitude, then at some point B will get to 10K, go huh that's a fun club-40 joke, and that point A and B will be far enough apart nobody will notice the discrepancy
There was a problem hiding this comment.
@Asartea, I think you are getting warmer. These messages are definitely more celebratory in tone.
But I think for anyone earning 5k+ points, represents a sincere and long-term commitment on the part of the receiver to helping innumerable learners on their journey, and I'd think that the messages beyond even 1k (I know this PR is just for 5k points and 10k points) could/should be a message that would communicate thanks in a celebratory/congratulatory tone. Each is a milestone more than worthy for resting at, rather than a race to forty thousand points.
In a way, I like your initial suggestions more than the rewrites. They just could be more celebratory/congratulatory in nature.
Do you want to take another crack at the 5k and 10k messages?
|
|
Individual cases from 6-24 and 25-98? Ambitious :P |
No no, individual cases up to 40K |
There was a problem hiding this comment.
@Asartea, I think you are getting warmer. These messages are definitely more celebratory in tone.
But I think for anyone earning 5k+ points, represents a sincere and long-term commitment on the part of the receiver to helping innumerable learners on their journey, and I'd think that the messages beyond even 1k (I know this PR is just for 5k points and 10k points) could/should be a message that would communicate thanks in a celebratory/congratulatory tone. Each is a milestone more than worthy for resting at, rather than a race to forty thousand points.
In a way, I like your initial suggestions more than the rewrites. They just could be more celebratory/congratulatory in nature.
Do you want to take another crack at the 5k and 10k messages?
Because
People keep getting more points
This PR
Additional Information
Pull Request Requirements
location of change: brief description of changeformat, e.g.Callbacks command: Update verbiageBecausesection summarizes the reason for this PRThis PRsection has a bullet point list describing the changes in this PR