Skip to content

Fix: Improve icon contrast and text hierarchy Contributing and About Pages #4983

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Fix: Improve icon contrast and text hierarchy Contributing and About Pages #4983

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4b89bb6
git add . git commit -m "Improve icon contrast and text hierarchy on …
michellecaii Apr 30, 2025
fe375b7
update the number of Contributors
michellecaii Apr 30, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 7 additions & 5 deletions app/components/about_page/belief_component.html.erb
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,13 +1,15 @@
<div class="sm:grid sm:grid-cols-12 sm:gap-x-6 pb-14">
<div class="flex sm:col-span-2 justify-center ">
<%= image_tag @belief[:image_path], alt: '', class: 'w-20 h-20' %>
<div class="flex sm:col-span-2 justify-center">
<div class="w-20 h-20 flex items-center justify-center rounded-full bg-gray-700 dark:bg-white shadow-md">
Copy link
Member

@KevinMulhern KevinMulhern Apr 30, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The backgrounds being different from the surrounding background is drawing the eye a bit too much. You can test that by reading the belief content and noticing where your eyes want to go to. I think this will distract users from the main content.

What issues did you find with the contrast of these icons? They appear fine to me, and lighthouse isn't raising anything about em.

<%= inline_svg @belief[:image_path], class: "w-10 h-10 text-white dark:text-black" %>
</div>
</div>

<div class="sm:col-span-10 text-center sm:text-left space-y-3">
<h3 class="pt-10 sm:pt-0 text-lg font-semibold">
<div class="sm:col-span-10 text-center sm:text-left">
<h3 class="text-2xl font-semibold mb-2 text-gray-800 dark:text-white">
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like most of these changes, but the font size being bigger than the section title is throwing off the hierarchy:

Suggested change
<h3 class="text-2xl font-semibold mb-2 text-gray-800 dark:text-white">
<h3 class="text-lg font-semibold mb-2 text-gray-800 dark:text-white">

<%= @belief[:title] %>
</h3>
<p class="prose prose-gray dark:prose-invert text-gray-500 dark:text-gray-400">
<p class="leading-relaxed text-gray-600 dark:text-gray-300">
<%= @belief[:description].html_safe %>
</p>
</div>
Expand Down
2 changes: 1 addition & 1 deletion app/views/static_pages/about/_overview.html.erb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@

<%= render CardComponent.new(classes: 'col-span-3 lg:col-span-1') do |card| %>
<% card.with_body(classes: 'text-center') do %>
<p class="font-bold text-2xl">5000+</p>
<p class="font-bold text-2xl">6000+</p>
<p class="text-gray-500 dark:text-gray-400">Contributors</p>
<% end %>
<% end %>
Expand Down