Fix: Navbar and LogoComponent: Eliminate duplicate header logos #5209
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The navbar duplicates a home link under the logo in the top-left. One of the links hides its logo at smaller screens and the other hides it at larger screens, but both links always remain in the navbar, which presents an accessibility issue and confusing tab navigation behavior.
This PR:
small_iconin the logo component.LogoComponentrender using the small_icon slot.Issue
Closes #5200
Additional Things
Willing to change the style things. I figured it'd be nice to fully embed the display toggling when the small logo is present (so the small logo always has
"block lg:hidden", and the larger icon always has"hidden lg:block"when the small icon is there) because I figured there'd be no conceivable scenario where you'd want to display both of them at the same time. But I also realize it's adding some small behavior to the component that didn't really have much before. Would be glad to change to all styles coming from the outside if that's preferred.QA
LogoComponentrenders (like the footer or the mobile sidenav menu) to make sure nothing is wrong with them (I don't see any issues)