Skip to content

Conversation

@dsmchen
Copy link
Contributor

@dsmchen dsmchen commented Jan 9, 2026

Because

Currently, focus style colour contrast ratio is approx 2:1. It should be at least 3:1.

This PR

  • Change secondary button focus style in dark mode.

Issue

Closes #5202

Additional Information

Pull Request Requirements

  • I have thoroughly read and understand The Odin Project Contributing Guide
  • The title of this PR follows the keyword: brief description of change format, using one of the following keywords:
    • Feature - adds new or amends existing user-facing behavior
    • Chore - changes that have no user-facing value, refactors, dependency bumps, etc
    • Fix - bug fixes
  • The Because section summarizes the reason for this PR
  • The This PR section has a bullet point list describing the changes in this PR
  • I have verified all tests and linters pass after making these changes.
  • If this PR addresses an open issue, it is linked in the Issue section
  • If applicable, this PR includes new or updated automated tests

@github-project-automation github-project-automation bot moved this to 📋 Backlog / Ideas in Main Site Jan 9, 2026
@KevinMulhern KevinMulhern temporarily deployed to odin-review-app-pr-5211 January 10, 2026 12:28 Inactive
Copy link
Member

@KevinMulhern KevinMulhern left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @dsmchen

@github-project-automation github-project-automation bot moved this from 📋 Backlog / Ideas to 👀 In review in Main Site Jan 10, 2026
@KevinMulhern KevinMulhern merged commit 598c80f into TheOdinProject:main Jan 10, 2026
5 checks passed
@github-project-automation github-project-automation bot moved this from 👀 In review to ✅ Done in Main Site Jan 10, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

Bug (Keyboard Accessibility): Fix focus style of secondary button in dark mode

2 participants