Split P2/memcard, fix PjsgeAllocJsg bug, misc matches + cleanup - #268
Open
545u wants to merge 3 commits into
Open
Split P2/memcard, fix PjsgeAllocJsg bug, misc matches + cleanup#268545u wants to merge 3 commits into
545u wants to merge 3 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
P2/memcardand match a few functions.P2/stepzapbut ran into the short loop bug in two places in the same function. I wasn't able to figure out how to fix it. I mangled a few of the names and left it as ASM.P2/alarm..datasubsegments. Some of the subsegments have alignment issues even though the addresses should be correct. Should we open an issue for that?