Remove the need for NBTs on Thermal Augments#2510
Merged
Xefyr0 merged 5 commits intoThePansmith:mainfrom Mar 14, 2026
Merged
Conversation
WithersChat
approved these changes
Mar 5, 2026
Collaborator
WithersChat
left a comment
WithersChat
left a comment
There was a problem hiding this comment.
I remember you saying you tested this. If this works well then we good.
Contributor
Author
|
I tested it on my world and could properly get the augments with the right stat buffs using EMI Cheat Mode or by crafting the items. They also properly updated when modifying the augment's stats. Temporary 1/1 recipes to reset old augment's nbts could be added if wanted |
Collaborator
|
Please add those recipes 🥺 |
Contributor
Author
|
All done! :D |
Xefyr0
requested changes
Mar 13, 2026
Collaborator
Xefyr0
left a comment
Xefyr0
left a comment
There was a problem hiding this comment.
Looks great.
Since this gets rid of the only use of thermal.emi.tooltip would you mind getting rid of that too in each lang file? They're located in kubejs/assets/kubejs/lang/.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Modify the Thermal Augments Item Properties on startup instead of adding NBTs to recipes.
Players can now successfully pick up augments from EMI
All previously crafted augments will be automatically updated if their stats are changed (Unless they already have NBT)