Add modify option before executing shell commands#628
Open
eadadi wants to merge 5 commits intoTheR1D:mainfrom
Open
Add modify option before executing shell commands#628eadadi wants to merge 5 commits intoTheR1D:mainfrom
eadadi wants to merge 5 commits intoTheR1D:mainfrom
Conversation
Author
|
is it going to be merged/checked/anything? |
Owner
|
Hello @eadadi, thank you for your contibution. It is a great feature, but It is a bit problematic to check new PRs that are not fully following contribution requirements. Could you please make sure the existing tests and linting tools are passing and add at least one more test in order to test new feature (if possible). |
additional changes in tests to reflect the new command
Author
|
Ok, I have modified the tests to reflect the change. |
Author
|
Also, tests and lint are passing |
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Sometimes we need to make modifications to the suggested prompt before executing it.
This patch adds [M]odify option to the suggested prompt