Fix failing unit tests #733
Merged
+114
−119
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR fixes a bug where the global additional_kwargs dictionary was being modified when functions are used, causing unintended side effects across multiple API calls. The fix creates a local copy of the dictionary before modifying it.
- Creates a local copy of
additional_kwargsbefore modification to prevent mutation of the global variable - Updates the completion call to use the local copy instead of the global dictionary
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
TheR1D
force-pushed
the
ut-fix
branch
3 times, most recently
from
2cc0898 to
d6f1e81
Compare
TheR1D
force-pushed
the
ut-fix
branch
11 times, most recently
from
ff39f0a to
036b410
Compare
Owner
Author
|
TODO: some of the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.