feat: add DEFAULT_TOP_PROBABILITY config option - #790
Open
codexanima1 wants to merge 1 commit into
Open
Conversation
Allow users to set default top_p value in .sgptrc config file or via DEFAULT_TOP_PROBABILITY environment variable. Previously top_p was hardcoded to 1.0. Now it reads from: 1. DEFAULT_TOP_PROBABILITY env var 2. sgptrc config file 3. Falls back to 1.0 Closes TheR1D#425
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR adds the ability to configure
top_p(top probability) via the.sgptrcconfig file orDEFAULT_TOP_PROBABILITYenvironment variable, just likeDEFAULT_TEMPERATUREalready works.Changes
DEFAULT_TOP_PROBABILITYto the default config (falls back to1.0)top_pdefault from hardcoded1.0tocfg.get("DEFAULT_TOP_PROBABILITY")Testing
top_pnow reads from config/env vars with a fallback to1.0DEFAULT_TEMPERATURECloses #425