[pull] trunk from spiceai:trunk#698
Merged
Merged
Conversation
Co-authored-by: Spice Schema Bot <schema-bot@spice.ai> Co-authored-by: Luke Kim <80174+lukekim@users.noreply.github.com>
* Improve JSON SODA support * Fix calendar_date to Timestamp(Second), fix clippy match_same_arms, rustfmt * Propagate soda_metadata in file_source() * Remove unused dependency 'arrow-schema' and update json_format description for clarity * fix: include JSON formats in HTTPS is_structured_format check Add json, jsonl, ndjson, ldjson, soda, and socrata to the explicit file_format check in is_structured_format(). Also add json, jsonl, ndjson, ldjson to the URL extension auto-detect check. This ensures that when file_format is set to a JSON-family format on an HTTPS dataset, it correctly routes to ListingTableConnector (which handles json_format, json_pointer, soda_metadata, etc.) instead of falling through to HttpTableProvider. * feat: Add rusqlite dependency and create SQLite tables for ADBC connector tests * fix: pre-create ADBC SQLite tables before load_components The ADBC connector calls GetTableSchema during load_components(), which requires tables to already exist. Previously the tests created tables after load_components(), causing 'no such table' errors and 60s timeouts. - Add rusqlite dev-dependency for direct SQLite table creation - Use tempfile::TempDir for automatic cleanup (even on panic) - Make setup_sqlite_table idempotent with DROP TABLE IF EXISTS - Pre-create tables with schema and seed data before runtime starts * feat: Add driver options, catalog, and schema parameters to ADBC connector * fix: Ensure ADBC driver options are prefixed with 'adbc.' in configuration * fix: Remove redundant note about read-only connection option in README * fix: Ignore ADBC options with empty keys and update SQLite table setup function * fix: Improve ADBC option logging and update SQLite test for prepopulated data * Fix dialect * Lint --------- Co-authored-by: Viktor Yershov <viktor@spice.ai>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )