Skip to content

[pull] trunk from spiceai:trunk#715

Merged
pull[bot] merged 3 commits into
TheRakeshPurohit:trunkfrom
spiceai:trunk
Mar 24, 2026
Merged

[pull] trunk from spiceai:trunk#715
pull[bot] merged 3 commits into
TheRakeshPurohit:trunkfrom
spiceai:trunk

Conversation

@pull
Copy link
Copy Markdown

@pull pull Bot commented Mar 24, 2026

See Commits and Changes for more details.


Created by pull[bot] (v2.0.0-alpha.4)

Can you help keep this open source service alive? 💖 Please sponsor : )

lukekim and others added 3 commits March 23, 2026 22:10
* feat: add support for custom authentication header in GraphQL client

* fix: address PR review - fix auth logic, add tests, revert unrelated changes

- Fix auth selection: Basic auth now works even when auth_header is set but token is missing
- Add 9 unit tests: auth selection logic + request_with_auth behavior for all variants
- Add 2 integration tests: custom auth header verification, json_pointer + query combinations
- Revert unrelated changes to cayenne, datafusion/mod.rs, and data_components/lib.rs

* fix: add warning when auth_header is set but auth_token is missing

* Address PR review: use prefixed param names in messages, improve test error handling

* fix: Apply cargo fmt to tracing::warn macro call

* Address PR review: generic warning messages, warn on auth_header without credentials, refactor test server helper

* fix: Correct test_graphql_json_pointer_combinations assertion to match SELECT query
* Fix ADBC Catalog

* fix

* Fix

* Fix

* Add more basic integration tests for distributed accelerations (#9740)

* more basic tests for distributed accelerations

* Refactor distributed acceleration tests to use async file operations and improve wait logic

* Potential fix for pull request finding

Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>

* Improve wait_for_row_count robustness and fix doc comment

* Fix lint errors and update inline snapshots for distributed acceleration tests

- Replace #[allow] with #[expect] (clippy::allow-attributes)
- Add backticks around TEST_DATA_CSV in doc comment (clippy::doc-markdown)
- Replace match with if let for single-pattern destructuring (clippy::single-match)
- Add #[expect(clippy::cast_possible_truncation)] for i64-to-usize cast
- Update inline snapshots to include bucket partition filters in plans

* formatting

* fix: use r#"..."# raw strings for insta snapshots containing double quotes

Entire-Checkpoint: 7f5359852068

* fix snapshots

---------

Co-authored-by: Luke Kim <80174+lukekim@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>

* Refactor ADBC functions to be crate-private and update tests for driver options

* Refactor import statements in adbc.rs

---------

Co-authored-by: Jack Eadie <jack@spice.ai>
Co-authored-by: Luke Kim <80174+lukekim@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
* Add --endpoint flag to spice run with scheme-based routing

Add a new --endpoint flag that auto-routes to the appropriate endpoint
based on URL scheme:
- http:// or https:// -> HTTP endpoint (--http)
- grpc:// or grpc+tls:// -> Flight endpoint (--flight)

Returns an error if no recognized scheme is provided, or if --endpoint
conflicts with an already-specified --http-endpoint or --flight-endpoint.

Fixes #9901

* Fix rustfmt formatting in resolve_endpoint
@pull pull Bot locked and limited conversation to collaborators Mar 24, 2026
@pull pull Bot added the ⤵️ pull label Mar 24, 2026
@pull pull Bot merged commit 1a5ee49 into TheRakeshPurohit:trunk Mar 24, 2026
1 of 9 checks passed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants