Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 3 additions & 4 deletions .github/actions/configure-apt/action.yml
Original file line number Diff line number Diff line change
Expand Up @@ -62,13 +62,12 @@ runs:
sudo sed -i -E \
-e "s|^URIs:[[:space:]]*https?://archive\.ubuntu\.com/ubuntu/?$|URIs: ${ALL_MIRRORS}|" \
/etc/apt/sources.list.d/ubuntu.sources
# Fail loudly if the substitution had no effect. Check that the
# configured primary mirror is now in the file.
# If the substitution had no effect, surface diagnostics but do not
# fail the action.
if ! grep -Fq "${PRIMARY}" /etc/apt/sources.list.d/ubuntu.sources; then
echo "ERROR: configure-apt: primary mirror ${PRIMARY} not found in ubuntu.sources after substitution" >&2
echo "::warning::configure-apt: primary mirror ${PRIMARY} not found in ubuntu.sources after substitution attempt"
echo "--- current ubuntu.sources URIs ---" >&2
grep '^URIs:' /etc/apt/sources.list.d/ubuntu.sources >&2 || true
exit 1
fi
fi
if [ -f /etc/apt/sources.list ]; then
Expand Down
8 changes: 4 additions & 4 deletions .github/copilot-instructions.md
Original file line number Diff line number Diff line change
Expand Up @@ -53,9 +53,9 @@ cargo run -p testoperator -- run bench -p ./test/spicepods/tpch/sf1/federated/du

### Rust Version Baseline

- **Workspace Rust version is 1.93.1**: Treat Rust 1.93.1 as the minimum supported compiler version for workspace code unless a specific crate or integration explicitly documents a different constraint.
- **Use stable Rust features through 1.93.1**: Prefer stable language, standard library, and Cargo features available in Rust 1.93.1 when they improve correctness, clarity, ergonomics, or maintainability.
- **Do not code to an older Rust subset by default**: Avoid workarounds for pre-1.93 compilers unless there is a concrete compatibility requirement.
- **Workspace Rust version is 1.94.1**: Treat Rust 1.94.1 as the minimum supported compiler version for workspace code unless a specific crate or integration explicitly documents a different constraint.
- **Use stable Rust features through 1.94.1**: Prefer stable language, standard library, and Cargo features available in Rust 1.94.1 when they improve correctness, clarity, ergonomics, or maintainability.
- **Do not code to an older Rust subset by default**: Avoid workarounds for pre-1.94 compilers unless there is a concrete compatibility requirement.
- **Prefer modern std APIs over manual patterns**: When a newer stable standard-library API expresses the intent more clearly or avoids extra allocation or unsafe code, use it.

### Error Handling (CRITICAL)
Expand Down Expand Up @@ -498,7 +498,7 @@ export PATH="$PATH:$HOME/.spice/bin"
3. Spicepod is YAML config format
4. Integration tests need credentials (`spice login` or `.env`)
5. testoperator is the test harness
6. Workspace uses Rust edition 2024 and rust-version 1.93.1; use stable Rust features available through 1.93.1 by default
6. Workspace uses Rust edition 2024 and rust-version 1.94.1; use stable Rust features available through 1.94.1 by default
7. New files should include copyright header. The current year is 2026. Required file types: `.rs`, `.go`
8. **Spice runtime (Rust) is 64-bit minimum**: The runtime requires at least 64-bit pointer size. Do not add 32-bit compatibility code. Code should assume `usize` is at least 64 bits but not assume it's exactly 64 bits (future 128-bit support).

Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/generate-openapi.yml
Original file line number Diff line number Diff line change
Expand Up @@ -38,9 +38,9 @@ jobs:
env:
GH_TOKEN: ${{ secrets.GITHUB_TOKEN }}

- name: Install Rust 1.93.1
- name: Install Rust 1.94.1
if: steps.check_pr.outputs.skip != 'true'
run: rustup toolchain install 1.93.1 --profile minimal
run: rustup toolchain install 1.94.1 --profile minimal

- name: Set up make
if: runner.os != 'macOS' && steps.check_pr.outputs.skip != 'true'
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/generate_acknowledgements.yml
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ jobs:
steps:
- uses: actions/checkout@8e8c483db84b4bee98b60c0593521ed34d9990e8 # v6

- run: rustup toolchain install 1.93.1 --profile minimal
- run: rustup toolchain install 1.94.1 --profile minimal

- name: Set up make
if: runner.os != 'macOS'
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/generate_json_schema.yml
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ jobs:
steps:
- uses: actions/checkout@8e8c483db84b4bee98b60c0593521ed34d9990e8 # v6

- run: rustup toolchain install 1.93.1 --profile minimal
- run: rustup toolchain install 1.94.1 --profile minimal

- name: Set up make
if: runner.os != 'macOS' && (github.event_name != 'workflow_dispatch' || inputs.run_build)
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/types_check.yml
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ jobs:
- name: Set REL_VERSION from version.txt
run: python3 ./.github/scripts/get_release_version.py

- run: rustup toolchain install 1.93.1 --profile minimal
- run: rustup toolchain install 1.94.1 --profile minimal

- uses: Swatinem/rust-cache@c19371144df3bb44fab255c43d04cbc2ab54d1c4 # v2
with:
Expand Down
2 changes: 1 addition & 1 deletion Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -84,7 +84,7 @@ exclude = [".github/"]
homepage = "https://spice.ai"
license = "Apache-2.0"
repository = "https://github.com/spiceai/spiceai"
rust-version = "1.93.1"
rust-version = "1.94.1"
version = "2.0.0-unstable"

[workspace.dependencies]
Expand Down
2 changes: 1 addition & 1 deletion Dockerfile
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
#syntax=docker/dockerfile:1.2
ARG RUST_VERSION=1.93.1
ARG RUST_VERSION=1.94.1
FROM rust:${RUST_VERSION}-slim-bookworm as build

# cache mounts below may already exist and owned by root
Expand Down
2 changes: 1 addition & 1 deletion Dockerfile-cuda
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
#syntax=docker/dockerfile:1.2
ARG RUST_VERSION=1.93.1
ARG RUST_VERSION=1.94.1

FROM nvidia/cuda:12.2.2-cudnn8-devel-ubuntu22.04 AS build

Expand Down
2 changes: 1 addition & 1 deletion crates/data-connectors/connector-nfs/Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
name = "connector-nfs"
edition = "2024"
version = "1.11.0-unstable"
rust-version = "1.93.1"
rust-version = "1.94.1"
license = "Apache-2.0"
description = "NFS data connector for Spice.ai runtime"

Expand Down
Loading
Loading