[pull] trunk from spiceai:trunk#759
Merged
Merged
Conversation
…10420) * fix: Map Utf8/LargeUtf8 to STRING in Databricks/Spark SQL dialects * Fix lint
Add an optional `prefix` field to `runtime.telemetry.otel_exporter` that
prepends a configurable string to every exported metric name. Useful for
namespacing Spice metrics in shared backends (e.g. Datadog) so they
don't collide with metrics from other services.
Example:
runtime:
telemetry:
otel_exporter:
endpoint: https://otlp.us3.datadoghq.com/v1/metrics
headers:
DD-API-KEY: ${secrets:dd_api_key}
prefix: "spiceai."
With this config the runtime metric `query_duration_ms` is exported as
`spiceai.query_duration_ms`.
The prefix is implemented via an OpenTelemetry `View` on the runtime's
`SdkMeterProvider`, which renames every instrument at the SDK layer.
Because the View is provider-wide, the prefix also applies to the
Prometheus scrape endpoint and the cluster on-demand OTLP reader if
those are enabled in the same process. In typical deployments only one
metrics destination is configured at a time, so the prefix appears on
exactly the destination the user configured it for. This trade-off is
documented on the field.
Athena (Trino) doesn't support the `TEXT` type which is used by DataFusion as default `CustomDialect` type mapping for `LargeUtf8` Fix by setting `.with_large_utf8_cast_dtype(Varchar(None))` on the Athena dialect so both `Utf8` and `LargeUtf8` map to `VARCHAR
Bumps the docker-dependencies group with 1 update: ubuntu. Updates `ubuntu` from 22.04 to 24.04 --- updated-dependencies: - dependency-name: ubuntu dependency-version: '24.04' dependency-type: direct:production dependency-group: docker-dependencies ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )