[pull] trunk from spiceai:trunk#790
Merged
Merged
Conversation
…nferred (#10601) When a Hadoop catalog's warehouse root scheme (e.g. `s3://`) does not match the scheme used in the table metadata locations (e.g. `s3a://`), the existing scheme inference logic in `HadoopCatalogBuilder::inner_build` rebuilds the catalog with the inferred warehouse root. However, since the iceberg-rust v0.9 upgrade (#9917), the `OpenDalStorageFactory::S3` variant validates that paths match its `configured_scheme`. If the factory was constructed with `configured_scheme: \"s3\"` but the rebuilt catalog tries to operate on `s3a://...` paths, it errors with: DataInvalid => Invalid s3 url: s3a://hadoop/, should start with s3://hadoop/ This caused the `catalogs/iceberg-hadoop` cookbook recipe to fail to register its catalog (the recipe writes table metadata via Spark using `s3a://`). Fix: - Add `HadoopCatalogBuilder::with_storage_factory_builder(Fn(&str) -> Arc<...>)`, a closure that produces a `StorageFactory` for a given URL scheme. When set, the factory is materialized in `inner_build` from the current warehouse root scheme, which allows scheme inference to rebuild the factory with the inferred scheme on the recursive `inner_build(false)` call. - Update the iceberg catalog connector to use the new builder closure for the S3 case, so the `CustomAwsCredentialLoader` is captured and the factory is rebuilt with the correct scheme when inferred. - Add a regression test `get_s3_to_s3a_inferred_hadoop_catalog` that configures the warehouse root as `s3://hadoop/` (while the underlying metadata uses `s3a://hadoop/`) and verifies the catalog builds successfully via scheme inference + factory rebuild.
* v2.0.0-rc.4 release notes * Fix * Fix * PM edits Co-authored-by: Copilot <copilot@github.com> --------- Co-authored-by: Luke Kim <80174+lukekim@users.noreply.github.com> Co-authored-by: Copilot <copilot@github.com>
Replace license.workspace = true with license-file.workspace = true across all workspace crates, and update [workspace.package] to use license-file = "LICENSE" instead of license = "Apache-2.0".
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )