[pull] trunk from spiceai:trunk#839
Merged
Merged
Conversation
* fix: Update tpch benchmark snapshots for federated/glue[csv].yaml * fix: Update tpch benchmark snapshots for federated/s3[parquet].yaml * fix: Update tpch benchmark snapshots for federated/mongodb.yaml * fix: Update tpch benchmark snapshots for federated/abfs[parquet].yaml * fix: Update tpch benchmark snapshots for federated/iceberg[catalog].yaml * fix: Update tpch benchmark snapshots for federated/dynamodb.yaml * Fix CH-BenCHmark replication lag metrics calculation (#10836) * fix: Update tpch benchmark snapshots for federated/glue[catalog].yaml * fix: Update tpch benchmark snapshots for federated/mssql.yaml * fix: Update tpch benchmark snapshots for federated/oracle.yaml * fix: Update tpch benchmark snapshots for federated/oracle[catalog].yaml * fix: Update tpch benchmark snapshots for federated/glue[parquet].yaml * fix: Update tpch benchmark snapshots for federated/iceberg[hadoop].yaml * fix: Update tpch benchmark snapshots for federated/abfs_standard_versioned[parquet].yaml * fix: Update tpch benchmark snapshots for federated/file[parquet].yaml * fix: Update tpch benchmark snapshots for federated/scylladb.yaml * fix: Update tpch benchmark snapshots for federated/mssql[catalog].yaml * fix: Update tpch benchmark snapshots for accelerated/s3[parquet]-cayenne[file]-partitioned.yaml * fix: Update tpch benchmark snapshots for accelerated/spicecloud-arrow.yaml * fix: Update tpch benchmark snapshots for accelerated/indexes/file[parquet]-cayenne[file]-indexes.yaml * fix: Update tpch benchmark snapshots for accelerated/indexes/file[parquet]-arrow-indexes.yaml * fix: Update tpch benchmark snapshots for accelerated/s3[parquet]-arrow-partitioned.yaml * fix: Update tpch benchmark snapshots for accelerated/dynamodb-arrow.yaml * fix: Update tpch benchmark snapshots for accelerated/mongodb-arrow.yaml * fix: Update tpch benchmark snapshots for accelerated/s3[parquet]-arrow.yaml * fix: Update tpch benchmark snapshots for accelerated/dynamodb-duckdb[file].yaml * fix: Update tpch benchmark snapshots for accelerated/file[parquet]-arrow.yaml * fix: Update tpch benchmark snapshots for accelerated/file[parquet]-cayenne[file]turso.yaml * fix: Update tpch benchmark snapshots for accelerated/file[parquet]-cayenne[file].yaml * fix: Update tpch benchmark snapshots for accelerated/on_zero_results/file[parquet]-cayenne[file]-on_zero_results.yaml * fix: Update tpch benchmark snapshots for accelerated/on_zero_results/file[parquet]-duckdb[file]-on_zero_results.yaml * fix: Update tpch benchmark snapshots for accelerated/on_zero_results/file[parquet]-duckdb[memory]-on_zero_results.yaml * fix: Update tpch benchmark snapshots for accelerated/mysql-arrow.yaml * fix: Update tpch benchmark snapshots for accelerated/s3[parquet]-duckdb[file]-partitioned.yaml * fix: Update tpch benchmark snapshots for accelerated/postgres-arrow.yaml * fix: Update tpcds benchmark snapshots for federated/s3[parquet].yaml * fix: Update tpcds benchmark snapshots for federated/abfs[parquet].yaml * fix: Update tpcds benchmark snapshots for federated/file[parquet].yaml * fix: Update tpcds benchmark snapshots for federated/databricks[delta_lake].yaml * fix: Update tpcds benchmark snapshots for accelerated/spicecloud-arrow.yaml * fix: Update tpcds benchmark snapshots for accelerated/databricks[delta_lake]-arrow.yaml * fix: Update tpcds benchmark snapshots for accelerated/s3[parquet]-arrow-partitioned.yaml * fix: Update tpcds benchmark snapshots for accelerated/s3[parquet]-arrow.yaml * fix: Update tpcds benchmark snapshots for accelerated/file[parquet]-arrow.yaml * fix: Update tpcds benchmark snapshots for accelerated/s3[parquet]-cayenne[file].yaml * fix: Update tpcds benchmark snapshots for accelerated/on_zero_results/file[parquet]-cayenne[file]-on_zero_results.yaml * fix: Update tpcds benchmark snapshots for accelerated/file[parquet]-cayenne[file].yaml * fix: Update tpcds benchmark snapshots for accelerated/on_zero_results/file[parquet]-duckdb[file]-on_zero_results.yaml * fix: Update tpcds benchmark snapshots for accelerated/on_zero_results/file[parquet]-duckdb[memory]-on_zero_results.yaml * fix: Update tpcds benchmark snapshots for accelerated/postgres-arrow.yaml * fix: Update clickbench benchmark snapshots for accelerated/on_zero_results/file[parquet]-cayenne[file]-on_zero_results_small.yaml * fix: Update tpch benchmark snapshots for accelerated/s3[parquet]-arrow.yaml * fix: Update tpch benchmark snapshots for accelerated/s3[parquet]-cayenne[file].yaml * fix: Update tpch benchmark snapshots for accelerated/mongodb-duckdb[file]-changes.yaml --------- Co-authored-by: Spice Benchmark Snapshot Update Bot <spiceaibot@spice.ai> Co-authored-by: Sergei Grebnov <sergei.grebnov@gmail.com>
* Upgrade iceberg to v0.9.1 * Update
* refactor(search): Split DuckDB vector index module into separate files Break up the monolithic duckdb.rs into focused submodules: - metric.rs: DuckDBDistanceMetric enum and distance/score expressions - hnsw.rs: DuckDBHnswOptions and HNSW index SQL generation - sql.rs: Vector search SQL builders (CTE and flat paths), filter pushdown - query_exec.rs: DuckDBVectorQueryExec ExecutionPlan implementation - query_table.rs: DuckDBVectorQueryTable TableProvider implementation - mod.rs: DuckDBVectorIndex, trait impls, shared utilities, re-exports Also improves DuckDBVectorQueryExec display to show metric, dims, scan type (hnsw vs brute_force), and projection columns. * style: Fix cargo fmt in query_exec.rs * fix: remove unused imports in search duckdb submodules * fix: remove trailing garbage bytes from query_exec.rs * update test for ef_search * fix: remove unused EMPTY_PROJECTION_ROW_COLUMN import; load vss on query connections * refactor: inject LOAD vss via pool setup query; RESET hnsw_ef_search after query * fix: remove redundant SET hnsw_ef_search; ef_search is baked into CREATE INDEX * fix: rustfmt import ordering in query_exec.rs * fix(search): pass pool by reference in with_query_context to satisfy clippy::needless_pass_by_value
…0858) Replace hand-rolled BinaryExpr recursion with existing DataFusion utilities: - s3_vectors_metadata_filter: collapse supports_filter_expr and its supports_binary_expr helper into a single Expr::apply traversal that recurses into AND/OR children and treats validated comparison / IS NULL / InList nodes as leaves via TreeNodeRecursion::Jump. - accelerated_table deletion tests: replace the recursive collect_or_conditions / collect_and_conditions helpers with a direct call to datafusion::logical_expr::utils::split_binary, which also handles Expr::Alias transparently. Co-authored-by: Claude <noreply@anthropic.com>
Opens https://spice.ai/slack in the user's default browser and prints the URL as a fallback for headless environments. Co-authored-by: Claude <noreply@anthropic.com>
* Executors should create catalog tables on join * add test 'test_distributed_cayenne_late_join_ddl_replay' * fix non-existant schema; fix SQL into query pipeline * comments * fix: use usize::try_from for since_version cast; add PARTITION BY to late-join DDL replay test * fix: add backticks around DataFusion in doc comments to satisfy clippy::doc_markdown --------- Co-authored-by: Jeadie <jeadie@users.noreply.github.com>
Co-authored-by: Luke Kim <80174+lukekim@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )