[pull] trunk from spiceai:trunk#840
Merged
Merged
Conversation
The metrics table builder declared six headers but every row added seven
cells, so `disk_write_operations` rendered without a label and the disk
columns were captioned with unrelated names ("DISK USED", "DISK AVAIL",
"DISK CAP"). Re-label so the header count matches the row count and the
labels accurately describe each metric (read/write bytes vs. ops).
Extract `metrics_table_headers()` and `metrics_table_row()` so a unit
test can assert the header count equals the row count and prevent this
regression class from recurring.
Fixes #9989
Co-authored-by: Luke Kim <80174+lukekim@users.noreply.github.com>
* fix: Deny nondistributed cayenne catalog * review: Address comments * chore: build * test: ignore tests which use cayenne catalog non-distributed * Update mod.rs --------- Co-authored-by: Luke Kim <80174+lukekim@users.noreply.github.com>
* Upgrade Turso to v0.6.0 * feat(turso): add support for NULLS FIRST/LAST ordering in queries and implement related test --------- Co-authored-by: Luke Kim <80174+lukekim@users.noreply.github.com>
* Remove rollback method from cloud client
The /v1/apps/{id}/rollback endpoint does not exist in the cloud API.
* remove rollback from CLI
* uncomment
* fix: remove CloudCommands::Rollback references from main.rs
The Rollback variant was removed from CloudCommands in mod.rs but two
references remained in main.rs:
- The is_json_output match arm for CloudCommands::Rollback
- The 'spice cloud rollback --output json' entry in the JSON commands list
* fix: remove extra blank line to satisfy rustfmt
---------
Co-authored-by: Jeadie <jeadie@users.noreply.github.com>
Co-authored-by: Luke Kim <80174+lukekim@users.noreply.github.com>
… (#10860) Adds three query parameters to /v1/ready so Kubernetes readiness probes can gate scheduler readiness on executor availability without restarting the scheduler: min_ready_executors=<u32> minimum currently-ready executors min_ready_executors_percent=<u8> minimum ready/registered ratio (0-100) verbose=true multi-line diagnostic body Decision logic: components must be ready (unchanged), then both supplied gates must pass. A value of 0 disables that gate. Percentage uses the currently-registered (control stream open) count as denominator so a dynamic fleet self-adapts (no peak-of-history poisoning, no restart asymmetry). Supplying a non-zero executor gate against a non-scheduler runtime returns 400 to surface misconfiguration. The verbose body mirrors Kubernetes /readyz?verbose, e.g.: [+] components ok [-] executors: 2/5 ready (40%, registered=5, min=3, min_percent=80%) not ready ExecutorRegistry gains ready_executor_count() and connected_executor_count() accessors over the existing maps; no new bookkeeping. Routes layer the optional registry onto the unauthenticated /v1/ready router. Co-authored-by: Luke Kim <80174+lukekim@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )