[pull] trunk from spiceai:trunk#858
Merged
Merged
Conversation
Two independent fixes: * EmbeddingTable::get_logical_plan now returns None. The forwarding added in #10795 caused LogicalPlanBuilder::scan to inline the inner ViewTable's logical plan (base columns only), then fail when the caller projected the embedding columns that EmbeddingTable adds on top. This made test_multi_column_search_view (and likely the flaky s3_vectors view+embeddings tests) consistently fail. Mirrors the existing IndexedTableProvider pattern, which already returns None for the same reason. * Add the missing snapshot files for test_explicit_dataset_search- ability_validation (introduced in #10968 without them): - explicit_non_searchable_dataset_errors_error_response - explicit_mixed_datasets_fail_fast_error_response - explicit_searchable_dataset_no_matches_returns_empty_response
…napshot exists (#10979) Co-authored-by: Phillip LeBlanc <879445+phillipleblanc@users.noreply.github.com>
…start (#11007) * fix lint * fix: re-insert offsets on seek failure and fix clippy redundant closures * fix(kafka): stash sidecar offsets at construction to close subscribe race The previous fix had callers invoke restore_offsets() after subscribe(), relying on the post_rebalance callback to fire later. Under cold-start or slow-broker conditions the assignment can arrive before the setter writes the stash — the callback sees None and the consumer falls back to auto.offset.reset=smallest, silently replaying from the beginning. Move the offsets into the consumer context at construction so the stash is in place before subscribe() can trigger a rebalance. The standalone restore_offsets() method is replaced by an argument on create_with_existing_group_id. Debezium's consumer construction moves below the schema-evolution check so post-evolution metadata.offsets are the ones threaded through. --------- Co-authored-by: Phillip LeBlanc <879445+phillipleblanc@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )