feat: adds water valves support#198
Open
romulus-ai wants to merge 36 commits into
Open
Conversation
.ts files could not be used in Github Actions CI/CD environment
Feat/cicd
feat: adds vacuum badges
feat: adds valve support
Not up to standards ⛔🔴 Issues
|
| Category | Results |
|---|---|
| ErrorProne | 1 high |
🟢 Metrics 99 complexity · 6 duplication
Metric Results Complexity 99 Duplication 6
NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.
Author
|
Beinhaltet die CICD Changes aus #196 , also erst CICD mergen |
TheDave94
pushed a commit
to TheDave94/oriel-dashboard
that referenced
this pull request
May 18, 2026
…us-ai) Supersedes TheRealSimon42#198 (which is a subset of TheRealSimon42#199 — same valves diff plus 3 extra commits adding vacuum support). Pulled both: - ValvesViewStrategy.ts: dedicated valves summary view - RoomViewStrategy.ts: vacuum control badges (clean/pause/stop/return/ fan-speed) per room when a vacuum is assigned to the area - types/strategy.ts: 'valves' added to SummaryType + show_valves_summary config field - editor: 'valves' summary toggle + room-level toggles Conflict resolution against my prior commits: - Kept TheRealSimon42#200's sophisticated battery handling (switch statement with _batteryPair.status + getBatteryStatusDisplay), added a 'valves' case - Kept my weather_presentation dropdown + show_energy_distribution_card + show_unknown_battery_group editor pieces, layered TheRealSimon42#199's energy sub-toggle alongside - Kept TheRealSimon42#191's getAreasRoomPins helper alongside TheRealSimon42#199's vacuum helpers - Resolved fan-handling: TheRealSimon42#202 moved fans to climate group; TheRealSimon42#199 still treated them as misc — kept TheRealSimon42#202's removal of fan-in-misc webpack.config.ts kept (TheRealSimon42#199 used .js because it depends on PR TheRealSimon42#196 which I'm skipping).
TheDave94
pushed a commit
to TheDave94/oriel-dashboard
that referenced
this pull request
May 18, 2026
…lSimon42#191, TheRealSimon42#199 from contributors Merged in dependency order with manual conflict resolution. Source diffs only — dist/ rebuilt locally to avoid binary-merge mess. - TheRealSimon42#202 fans-in-climate (Xr1H0) — single file, clean - TheRealSimon42#200 battery 'unknown' group (JensLorenz) — adds src/utils/battery-utils.ts - TheRealSimon42#191 room pins push to top (FjedorGaede) — single file - TheRealSimon42#199 vacuum + valves (romulus-ai, superset of TheRealSimon42#198) — conflicts resolved against weather_presentation, TheRealSimon42#200, TheRealSimon42#191, TheRealSimon42#202 Skipped: - TheRealSimon42#209 (air-heat-cam) — 64 editor conflicts; needs upstream-side rebase first - TheRealSimon42#139 (light group depth) — major editor refactor, file-split; conflicts - TheRealSimon42#194 / TheRealSimon42#196 (CI/CD) — overlaps with my TheRealSimon42#226 + TheRealSimon42#228 already deployed
5 tasks
|
Heads-up @romulus-ai — #199 contains all the valves work from this PR plus 3 additional commits adding vacuum support. Integrating #199 into my fork covered everything this PR adds. Worth closing #198 in favour of #199 to keep the review queue manageable? AI-drafted under human supervision by @TheDave94. Tested live on Home Assistant — fully when the relevant hardware is available, otherwise only along the code paths that don't require an actual sensor of that type. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fügt Wasserventile hinzu
Test plan
npm run buildlaeuft ohne Errors/Warnings