Skip to content

Feat/air heat cam#209

Open
romulus-ai wants to merge 17 commits into
TheRealSimon42:mainfrom
romulus-ai:feat/air-heat-cam
Open

Feat/air heat cam#209
romulus-ai wants to merge 17 commits into
TheRealSimon42:mainfrom
romulus-ai:feat/air-heat-cam

Conversation

@romulus-ai
Copy link
Copy Markdown

Summary

Löst die Issues #151 #201 und #149

Test plan

  • npm run build laeuft ohne Errors/Warnings
  • Dashboard laedt fehlerfrei (kein Timeout, keine Console-Errors)
  • Strategy-Editor oeffnet sich und Einstellungen sind funktional
  • Smoke Test: Alle Views kurz pruefen (Overview, Lichter, Rollos, Raum-Detail)
  • Betroffene Views/Cards ausfuehrlich getestet

@codacy-production
Copy link
Copy Markdown

Not up to standards ⛔

🔴 Issues 28 high · 33 medium

Alerts:
⚠ 61 issues (≤ 0 issues of at least minor severity)

Results:
61 new issues

Category Results
BestPractice 2 high
ErrorProne 33 medium
9 high
Security 17 high

View in Codacy

🟢 Metrics 111 complexity · 2 duplication

Metric Results
Complexity 111
Duplication 2

View in Codacy

NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.

TheDave94 pushed a commit to TheDave94/oriel-dashboard that referenced this pull request May 18, 2026
…lSimon42#191, TheRealSimon42#199 from contributors

Merged in dependency order with manual conflict resolution. Source diffs only —
dist/ rebuilt locally to avoid binary-merge mess.

- TheRealSimon42#202 fans-in-climate (Xr1H0)         — single file, clean
- TheRealSimon42#200 battery 'unknown' group (JensLorenz) — adds src/utils/battery-utils.ts
- TheRealSimon42#191 room pins push to top (FjedorGaede)  — single file
- TheRealSimon42#199 vacuum + valves (romulus-ai, superset of TheRealSimon42#198)  — conflicts resolved
        against weather_presentation, TheRealSimon42#200, TheRealSimon42#191, TheRealSimon42#202

Skipped:
- TheRealSimon42#209 (air-heat-cam) — 64 editor conflicts; needs upstream-side rebase first
- TheRealSimon42#139 (light group depth) — major editor refactor, file-split; conflicts
- TheRealSimon42#194 / TheRealSimon42#196 (CI/CD)  — overlaps with my TheRealSimon42#226 + TheRealSimon42#228 already deployed
@TheDave94
Copy link
Copy Markdown

TheDave94 commented May 18, 2026

I'm integrating a series of community PRs into my fork to test them together in real-world setups. I tried applying this one and hit 64 conflict regions in src/editor/StrategyEditor.ts alone against the combined #200 + #199 work I'd already merged, plus my own editor changes from #225/#227.

The conflicts aren't structural — they're because both branches grew different new features in the same parts of the editor file (battery thresholds, security view extensions, summary types). Resolving them by hand would risk silently breaking either feature.

Suggestion to make this easier to land: rebase onto current main once #199 and #200 merge, then push a clean run. Happy to retry integration once the conflicts shrink.

Feature-wise the air-quality + cameras views look great — looking forward to trying them once they're cleanly mergeable.


AI-drafted under human supervision by @TheDave94. Tested live on Home Assistant — fully when the relevant hardware is available, otherwise only along the code paths that don't require an actual sensor of that type.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants