feat: configurable show_person_badges toggle (closes #148)#236
Closed
TheDave94 wants to merge 1 commit into
Closed
feat: configurable show_person_badges toggle (closes #148)#236TheDave94 wants to merge 1 commit into
show_person_badges toggle (closes #148)#236TheDave94 wants to merge 1 commit into
Conversation
Auto-generated person chip badges (createPersonBadges) appear in the overview header. Users running custom person badges via custom_badges had no way to suppress the defaults — leading to duplicate chips. Adds: - show_person_badges?: boolean (default true). When false, the auto badges are skipped entirely; custom_badges still flow through. - Editor checkbox in the Overview section + description. - de + en translations. Default-on so behaviour is unchanged for existing dashboards.
Up to standards ✅🟢 Issues
|
| Metric | Results |
|---|---|
| Complexity | 0 |
| Duplication | 0 |
NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.
Open
7 tasks
Author
|
Superseded by #276 — bundled with the other overview-presentation PRs because they all touch the badge builder, person handling, and overview section composition. Closing this one in favor of the bundled review. |
Author
1 task
TheDave94
added a commit
to TheDave94/oriel-dashboard
that referenced
this pull request
May 23, 2026
Bulk branch deletion in TheDave94/oriel-dashboard on 2026-05-19 and 2026-05-22 silently closed 49 cross-fork PRs in TheRealSimon42/simon42-dashboard-strategy. GitHub auto-closes a PR when its head branch is deleted, recording the deleting account as the close actor — looks like deliberate closure to the maintainer but isn't. All 49 PRs have since been recovered (Cluster C 17-PR batch restored on 2026-05-23; TheRealSimon42#250 restored after the rebundling-map investigation). The next bulk cleanup is the actual risk; this entry pins the safety check before any future automation lands. Recovery state at time of writing: 17 grouped/standalone Cluster C PRs open, TheRealSimon42#236 re-closed (superseded by TheRealSimon42#276 within Cluster C), TheRealSimon42#250 open as standalone. Remaining ~30 closed-not-merged originals from May 19 were deliberately rebundled into the grouped/* PRs and stay closed correctly. Co-authored-by: AutoCoder <autocoder@claudebox> Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #148.
Problem
Auto-generated person chip badges (via
createPersonBadges) appear in the overview header by default. Users running their own person badges throughcustom_badges(e.g. because they want a different home/away label than the integration's auto-derived one) had no way to suppress the defaults — leading to duplicate person chips next to each other.Change
Adds:
When
false, the auto badges are skipped entirely.custom_badgesstill flow through, so a user can swap the defaults for their own. Default istrue— existing behaviour unchanged.Editor UI
Adds a checkbox under the Overview section (alongside the existing search-card checkbox). With description text explaining why someone might want to disable.
Test plan
npm run build— greenshow_person_badges: false: person chips disappear from the headercustom_badgesstill render in their placeAI-drafted under human supervision by @TheDave94. Tested live on Home Assistant — fully when the relevant hardware is available, otherwise only along the code paths that don't require an actual sensor of that type.