fix(tests): align scripts and tests with bytes badge descriptions

Author: V-Vaal

the-guild-smart-contracts/script/CreateBadgesFromJson.s.sol

@@ -13,7 +13,7 @@ contract CreateBadgesFromJson is Script {
 
     struct BadgeData {
         bytes32 name;
-        bytes32 description;
+        string description;
     }
 
     function run() public {
@@ -76,7 +76,7 @@ contract CreateBadgesFromJson is Script {
                             ": ",
                             vm.toString(badges[i].name),
                             " - ",
-                            vm.toString(badges[i].description)
+                            badges[i].description
                         )
                     )
                 );
@@ -126,20 +126,14 @@ contract CreateBadgesFromJson is Script {
                 name := mload(add(nameBytes, 32))
             }
 
-            // Parse description with proper bytes32 conversion
-            string memory descriptionStr = abi.decode(
+            // Parse description as string
+            string memory description = abi.decode(
                 vm.parseJson(
                     jsonData,
                     string(abi.encodePacked(basePath, ".description"))
                 ),
                 (string)
             );
-            bytes32 description;
-            bytes memory descriptionBytes = bytes(descriptionStr);
-            require(descriptionBytes.length <= 32, "description too long");
-            assembly {
-                description := mload(add(descriptionBytes, 32))
-            }
 
             tempBadges[count] = BadgeData({
                 name: name,
@@ -215,7 +209,7 @@ contract CreateBadgesFromJson is Script {
                 continue;
             }
 
-            try badgeRegistry.createBadge(badge.name, badge.description) {
+            try badgeRegistry.createBadge(badge.name, bytes(badge.description)) {
                 console.log(
                     string(
                         abi.encodePacked(
@@ -226,7 +220,7 @@ contract CreateBadgesFromJson is Script {
                             ": ",
                             vm.toString(badge.name),
                             " - ",
-                            vm.toString(badge.description)
+                            badge.description
                         )
                     )
                 );

the-guild-smart-contracts/script/FullDeploymentScript.s.sol

@@ -56,15 +56,15 @@ contract FullDeploymentScript is Script {
         // Create some badges
         badgeRegistry.createBadge(
             bytes32("Rust"),
-            bytes32("Know how to code in Rust")
+            bytes("Know how to code in Rust")
         );
         badgeRegistry.createBadge(
             bytes32("Solidity"),
-            bytes32("Know how to code in Solidity")
+            bytes("Know how to code in Solidity")
         );
         badgeRegistry.createBadge(
             bytes32("TypeScript"),
-            bytes32("Know how to code in TypeScript")
+            bytes("Know how to code in TypeScript")
         );
 
         // Deploy or attach to existing badge ranking via CREATE2

the-guild-smart-contracts/script/TheGuildBadgeRegistry.s.sol

@@ -15,31 +15,31 @@ contract TheGuildBadgeRegistryScript is Script {
         }();
         registry.createBadge(
             bytes32("Rust"),
-            bytes32("Know how to code in Rust")
+            bytes("Know how to code in Rust")
         );
         registry.createBadge(
             bytes32("Solidity"),
-            bytes32("Know how to code in Solidity")
+            bytes("Know how to code in Solidity")
         );
         registry.createBadge(
             bytes32("Python"),
-            bytes32("Know how to code in Python")
+            bytes("Know how to code in Python")
         );
         registry.createBadge(
             bytes32("JavaScript"),
-            bytes32("Know how to code in JavaScript")
+            bytes("Know how to code in JavaScript")
         );
         registry.createBadge(
             bytes32("TypeScript"),
-            bytes32("Know how to code in TypeScript")
+            bytes("Know how to code in TypeScript")
         );
         registry.createBadge(
             bytes32("React"),
-            bytes32("Know how to code in React")
+            bytes("Know how to code in React")
         );
         registry.createBadge(
             bytes32("Next.js"),
-            bytes32("Know how to code in Next.js")
+            bytes("Know how to code in Next.js")
         );
         vm.stopBroadcast();
     }

the-guild-smart-contracts/test/TheGuildAttestationResolver.t.sol

@@ -51,7 +51,7 @@ contract TheGuildAttestationResolverTest is Test {
         // Ensure badge exists
         badgeRegistry.createBadge(
             bytes32("Rust"),
-            bytes32("Know how to code in Rust")
+            bytes("Know how to code in Rust")
         );
 
         // Build attestation request
@@ -142,7 +142,7 @@ contract TheGuildAttestationResolverTest is Test {
         bytes32 schemaId = _registerSchema();
         badgeRegistry.createBadge(
             bytes32("Rust"),
-            bytes32("Know how to code in Rust")
+            bytes("Know how to code in Rust")
         );
 
         vm.prank(attester);
@@ -171,7 +171,7 @@ contract TheGuildAttestationResolverTest is Test {
         bytes32 schemaId = _registerSchema();
         badgeRegistry.createBadge(
             bytes32("Rust"),
-            bytes32("Know how to code in Rust")
+            bytes("Know how to code in Rust")
         );
 
         vm.prank(attester);
@@ -204,7 +204,7 @@ contract TheGuildAttestationResolverTest is Test {
         // Ensure badge exists
         badgeRegistry.createBadge(
             bytes32("Rust"),
-            bytes32("Know how to code in Rust")
+            bytes("Know how to code in Rust")
         );
 
         AttestationRequest memory request = AttestationRequest({

the-guild-smart-contracts/test/TheGuildBadgeRanking.t.sol

@@ -18,7 +18,7 @@ contract TheGuildBadgeRankingTest is Test {
         ranking = new TheGuildBadgeRanking(registry);
 
         // Create a badge for testing
-        registry.createBadge(badgeName, bytes32("A test badge"));
+        registry.createBadge(badgeName, bytes("A test badge"));
     }
 
     function test_UpvoteBadge_SucceedsAndEmitsEvent() public {