[ZH] Fix weather settings memory leak in ~SnowManager() (#623)

Mauller · xezon · commit 7977983830c6 · 2025-05-09T16:45:57.000+02:00
diff --git a/GeneralsMD/Code/GameEngine/Source/GameClient/Snow.cpp b/GeneralsMD/Code/GameEngine/Source/GameClient/Snow.cpp
@@ -99,6 +99,13 @@ SnowManager::~SnowManager()
 {
 	delete [] m_startingHeights;
 	m_startingHeights=NULL;
+
+	// TheSuperHackers @fix Mauller 13/04/2025 Delete the instance of the weather settings
+	if (TheWeatherSetting)
+	{
+		((WeatherSetting*)TheWeatherSetting.getNonOverloadedPointer())->deleteInstance();
+		TheWeatherSetting=NULL;
+	}
 }
 
 OVERRIDE<WeatherSetting> TheWeatherSetting = NULL;

Original file line number	Diff line number	Diff line change
`@@ -99,6 +99,13 @@ SnowManager::~SnowManager()`
`99`	`99`	`{`
`100`	`100`	`delete [] m_startingHeights;`
`101`	`101`	`m_startingHeights=NULL;`
	`102`	`+`
	`103`	`+ // TheSuperHackers @fix Mauller 13/04/2025 Delete the instance of the weather settings`
	`104`	`+ if (TheWeatherSetting)`
	`105`	`+ {`
	`106`	`+ ((WeatherSetting*)TheWeatherSetting.getNonOverloadedPointer())->deleteInstance();`
	`107`	`+ TheWeatherSetting=NULL;`
	`108`	`+ }`
`102`	`109`	`}`
`103`	`110`
`104`	`111`	`OVERRIDE<WeatherSetting> TheWeatherSetting = NULL;`