Funny gems in code (Recreational)

[vnvx]

Submit funny things you found in code while reviewing (This was founded by @ThePrimeagen).

World nested "for/if" chain:

GeneralsGameCode/GeneralsMD/Code/Tools/matchbot/generals.cpp

Lines 522 to 699 in 0a05454

	void GeneralsMatcher::checkMatchesInUserMap(UserMap& userMap, int ladderID, int numPlayers, bool showPoolSize)
	{
	UserMap::iterator i1, i2, i3, i4, i5, i6, i7, i8;
	GeneralsUser *u1, *u2, *u3, *u4, *u5, *u6, *u7, *u8;
	static const double fitnessThreshold = 0.3;
	time_t now = time(NULL);
	std::string s;
	if (showPoolSize)
	{
	s = "MBOT:POOLSIZE ";
	s.append(intToString(userMap.size()));
	}
	// iterate through users, timing them out as neccessary
	for (i1 = userMap.begin(); i1 != userMap.end(); ++i1)
	{
	if (showPoolSize)
	{
	peerMessagePlayer(m_peer, i1->first.c_str(), s.c_str(), NormalMessage);
	}
	u1 = i1->second;
	if (u1->timeToWiden && u1->timeToWiden < now)
	{
	u1->timeToWiden = 0;
	u1->widened = true;
	for (int m=0; m<(int)u1->maps.size(); ++m)
	u1->maps[m] = 1;
	DBGMSG("Widening search for " << i1->first);
	peerMessagePlayer(m_peer, i1->first.c_str(), "MBOT:WIDENINGSEARCH", NormalMessage);
	}
	}
	// iterate through all users, looking for a match
	for (i1 = userMap.begin(); i1 != userMap.end(); ++i1)
	{
	u1 = i1->second;
	if (u1->status != STATUS_WORKING)
	continue;
	GeneralsUser *bestUser = NULL;
	double bestMatchFitness = 0.0;
	std::string bestName = "";
	// look at everybody left
	i2 = i1;
	for (++i2; i2 != userMap.end(); ++i2)
	{
	u2 = i2->second;
	if (u2->status != STATUS_WORKING)
	continue;
	double matchFitness = computeMatchFitness(i1->first, u1, i2->first, u2);
	if (matchFitness > fitnessThreshold)
	{
	if (numPlayers == 2)
	{
	if (matchFitness > bestMatchFitness)
	{
	// possibly match 2 players
	bestMatchFitness = matchFitness;
	bestUser = u2;
	bestName = i2->first;
	}
	}
	else
	{
	i3 = i2;
	for (++i3; i3 != userMap.end(); ++i3)
	{
	u3 = i3->second;
	if (u3->status != STATUS_WORKING)
	continue;
	double matchFitness1 = computeMatchFitness(i1->first, u1, i3->first, u3);
	double matchFitness2 = computeMatchFitness(i2->first, u2, i3->first, u3);
	MapBitSet tmp = MapSetUnion(u1->maps, u2->maps);
	tmp = MapSetUnion(tmp, u3->maps);
	if (MapSetCount(tmp) && matchFitness1 > fitnessThreshold && matchFitness2 > fitnessThreshold)
	{
	i4 = i3;
	for (++i4; i4 != userMap.end(); ++i4)
	{
	u4 = i4->second;
	if (u4->status != STATUS_WORKING)
	continue;
	double matchFitness1 = computeMatchFitness(i1->first, u1, i4->first, u4);
	double matchFitness2 = computeMatchFitness(i2->first, u2, i4->first, u4);
	double matchFitness3 = computeMatchFitness(i3->first, u3, i4->first, u4);
	MapBitSet tmp = MapSetUnion(u1->maps, u2->maps);
	tmp = MapSetUnion(tmp, u3->maps);
	tmp = MapSetUnion(tmp, u4->maps);
	if (MapSetCount(tmp) && matchFitness1 > fitnessThreshold && matchFitness2 > fitnessThreshold && matchFitness3 > fitnessThreshold)
	{
	if (numPlayers == 4)
	{
	// match 4 players
	sendMatchInfo(i1->first, i2->first, i3->first, i4->first, "", "", "", "",
	u1, u2, u3, u4, NULL, NULL, NULL, NULL, 4, ladderID);
	break;
	}
	else
	{
	i5 = i4;
	for (++i5; i5 != userMap.end(); ++i3)
	{
	u5 = i5->second;
	if (u5->status != STATUS_WORKING)
	continue;
	double matchFitness1 = computeMatchFitness(i1->first, u1, i5->first, u5);
	double matchFitness2 = computeMatchFitness(i2->first, u2, i5->first, u5);
	double matchFitness3 = computeMatchFitness(i3->first, u3, i5->first, u5);
	double matchFitness4 = computeMatchFitness(i4->first, u4, i5->first, u5);
	MapBitSet tmp = MapSetUnion(u1->maps, u2->maps);
	tmp = MapSetUnion(tmp, u3->maps);
	tmp = MapSetUnion(tmp, u4->maps);
	tmp = MapSetUnion(tmp, u5->maps);
	if (MapSetCount(tmp) && matchFitness1 > fitnessThreshold && matchFitness2 > fitnessThreshold && matchFitness3 > fitnessThreshold && matchFitness4 > fitnessThreshold)
	{
	i6 = i5;
	for (++i6; i6 != userMap.end(); ++i6)
	{
	u6 = i6->second;
	if (u6->status != STATUS_WORKING)
	continue;
	double matchFitness1 = computeMatchFitness(i1->first, u1, i6->first, u6);
	double matchFitness2 = computeMatchFitness(i2->first, u2, i6->first, u6);
	double matchFitness3 = computeMatchFitness(i3->first, u3, i6->first, u6);
	double matchFitness4 = computeMatchFitness(i4->first, u4, i6->first, u6);
	double matchFitness5 = computeMatchFitness(i5->first, u5, i6->first, u6);
	MapBitSet tmp = MapSetUnion(u1->maps, u2->maps);
	tmp = MapSetUnion(tmp, u3->maps);
	tmp = MapSetUnion(tmp, u4->maps);
	tmp = MapSetUnion(tmp, u5->maps);
	tmp = MapSetUnion(tmp, u6->maps);
	if (MapSetCount(tmp) && matchFitness1 > fitnessThreshold && matchFitness2 > fitnessThreshold && matchFitness3 > fitnessThreshold && matchFitness4 > fitnessThreshold && matchFitness5 > fitnessThreshold)
	{
	if (numPlayers == 6)
	{
	// match 6 players
	sendMatchInfo(i1->first, i2->first, i3->first, i4->first, i5->first, i6->first, "", "",
	u1, u2, u3, u4, u5, u6, NULL, NULL, 6, ladderID);
	break;
	}
	else
	{
	i7 = i6;
	for (++i7; i7 != userMap.end(); ++i7)
	{
	u7 = i7->second;
	if (u7->status != STATUS_WORKING)
	continue;
	double matchFitness1 = computeMatchFitness(i1->first, u1, i7->first, u7);
	double matchFitness2 = computeMatchFitness(i2->first, u2, i7->first, u7);
	double matchFitness3 = computeMatchFitness(i3->first, u3, i7->first, u7);
	double matchFitness4 = computeMatchFitness(i4->first, u4, i7->first, u7);
	double matchFitness5 = computeMatchFitness(i5->first, u5, i7->first, u7);
	double matchFitness6 = computeMatchFitness(i6->first, u6, i7->first, u7);
	MapBitSet tmp = MapSetUnion(u1->maps, u2->maps);
	tmp = MapSetUnion(tmp, u3->maps);
	tmp = MapSetUnion(tmp, u4->maps);
	tmp = MapSetUnion(tmp, u5->maps);
	tmp = MapSetUnion(tmp, u6->maps);
	tmp = MapSetUnion(tmp, u7->maps);
	if (MapSetCount(tmp) && matchFitness1 > fitnessThreshold && matchFitness2 > fitnessThreshold && matchFitness3 > fitnessThreshold && matchFitness4 > fitnessThreshold && matchFitness5 > fitnessThreshold && matchFitness6 > fitnessThreshold)
	{
	i8 = i7;
	for (++i8; i8 != userMap.end(); ++i8)
	{
	u8 = i8->second;
	if (u8->status != STATUS_WORKING)

Also Possibly a bug at line #629 but probably doesn't matter.

---

This Comment is gold

GeneralsGameCode/Generals/Code/GameEngine/Source/GameNetwork/NAT.cpp

Lines 51 to 66 in 0a05454

	/*
	* In case you're wondering, we do this weird connection pairing scheme
	* to speed up the negotiation process, especially in cases where there
	* are 4 or more players (nodes). Take for example an 8 player game...
	* In an 8 player game there are 28 connections that need to be negotiated,
	* doing this pairing scheme thing, we can make those 28 connections in the
	* time it would normally take to make 7 connections. Since each connection
	* could potentially take several seconds, this can be a HUGE time savings.
	* Right now you're probably wondering who this Bryan Cleveland guy is.
	* He's the network coder that got fired when this didn't work.
	* In case you're wondering, this did end up working and Bryan left by
	* his own choice.
	*/
	// m_connectionPairs[num nodes] [round] [node index]

[Chikinsupu]

The typo at line 629
for (++i5; i5 != userMap.end(); ++i3)

still should be fixed even though it's quite minor. Did someone create an issue for that already?

[xezon]

gogogo

[xmesaj2]

GeneralsGameCode/GeneralsMD/Code/GameEngine/Source/GameLogic/Object/Object.cpp

Lines 966 to 967 in 9f1643d

	if( victim && ourBoobyTrap->getControllingPlayer()->getRelationship(victim->getTeam()) == ALLIES )
	return FALSE;// Friends don't touch friends boobies.

my favourite

[valeronm]

This one funny and sad at the same time

GeneralsGameCode/GeneralsMD/Code/GameEngine/Include/Common/GlobalData.h

Lines 58 to 64 in 9f8620a

	//-------------------------------------------------------------------------------------------------
	/** Global data container class
	* Defines all global game data used by the system
	* @todo Change this entire system. Otherwise this will end up a huge class containing tons of variables,
	* and will cause re-compilation dependancies throughout the codebase.
	* OOPS -- TOO LATE! :) */
	//-------------------------------------------------------------------------------------------------