VS6 garrison crash issue [Bug][ZH][vs6]

[Pekaman]

If we garrison and ungarrison and repeat this step 4-5 times and try interacting with any other command button like an upgrade or trying to build a unit will crash the game which is not expected behavior and does not happen with original version.

Steps to reproduce

• Build GLA Tunnel
• Garrison RPG Troopers inside Tunnel
• Evacuate RPG Troopers
• Repeat X>6 times
• Purchase CamoNetting Upgrade for GLA Tunnel

Proof

GLA Tunnel Video Example

[xezon]

According to Pekaman this happens with our first (clean) VS6 build already.

[sorcerer86pt]

According to Pekaman this happens to all factions , with their garrison/ungarrison mechanic. USA with the helicopters and china with bunkers.

PS: Everything that can be garrisoned (even Humvee's)

[DevGeniusCode]

I tested it in debug mode and got the following message:

[sorcerer86pt]

Probability/severity scale: low probability - high severity: 5

[Pekaman]

Turns out you dont need units to reproduce, just clicking on the empty slots of anything garrison able will make the environment needed for a crash.

[roossienb]

Easy to reproduce:
As USA

• Build barracks
• Build a chinook
• Upgrade flashbangs
• While the upgrade is researching, select chinook, click once on an (empty) slot
• Select barracks -> crash

Confirmed in both 20250309 and 20250316 builds

Video:
https://app.filen.io/#/d/d52f01a0-8fc3-4a14-b355-a6536336c5df%23ySO6064FExvzusOeuay3ObAk33YiCVo0

[xezon]

So what I am seeing is quite a lot of small stalls. That needs to be checked as well.

I was able to reproduce a crash when clicking things.

The callstack looks total garbage - it makes no sense. I see garbage callstack on vs2022 build as well, but much much earlier.

There seems to be a grand memory corruption at large.

(30fc.256c): Access violation - code c0000005 (first chance)
First chance exceptions are reported before any exception handling.
This exception may be expected and handled.
*** WARNING: Unable to verify checksum for C:\Generals\English\Command & Conquer Generals Zero Hour\generals.exe
eax=00000000 ebx=062715c8 ecx=00000000 edx=00977204 esi=062717e0 edi=062717e0
eip=004fa090 esp=0019f9e0 ebp=00a4a5ac iopl=0         nv up ei pl zr na pe nc
cs=0023  ss=002b  ds=002b  es=002b  fs=0053  gs=002b             efl=00010246
generals!ActionManager::canHijackVehicle+0x16b:
004fa090 8b4104          mov     eax,dword ptr [ecx+4] ds:002b:00000004=????????
0:000> !except
No export except found
0:000> k
 # ChildEBP RetAddr  
00 0019f9dc 005a58c0 generals!ActionManager::canHijackVehicle+0x16b [D:\Projects\TheSuperHackers\GeneralsGameCode\GeneralsMD\Code\GameEngine\Source\Common\RTS\ActionManager.cpp @ 912] 
01 0019f9f8 004fb5c9 generals!std::_Rb_tree<int,std::pair<int const ,MultiplayerColorDefinition>,std::_Select1st<std::pair<int const ,MultiplayerColorDefinition> >,std::less<int>,std::allocator<std::pair<int const ,MultiplayerColorDefinition> > >::insert_unique+0x360 [D:\Projects\TheSuperHackers\GeneralsGameCode\build\vc6\_deps\stlport-src\.\stl/_tree.c @ 504] 
02 0019fa0c 005a5b0d generals!ActionManager::canFireWeapon+0xa [D:\Projects\TheSuperHackers\GeneralsGameCode\GeneralsMD\Code\GameEngine\Source\Common\RTS\ActionManager.cpp @ 1993] 
03 0019fa2c 0045f9cc generals!std::__uninitialized_copy+0xd [D:\Projects\TheSuperHackers\GeneralsGameCode\build\vc6\_deps\stlport-src\.\stl/_uninitialized.h @ 63] 
04 0019fa30 0045fa35 generals!$E482+0x18
05 0019fa5c 0050be4d generals!$E485+0x3c [D:\Projects\TheSuperHackers\GeneralsGameCode\GeneralsMD\Code\GameEngine\Source\GameLogic\ScriptEngine\ScriptEngine.cpp @ 9750] 
06 0019faac 004ae0c2 generals!std::list<enum ObjectID,std::allocator<enum ObjectID> >::insert+0xd [D:\Projects\TheSuperHackers\GeneralsGameCode\build\vc6\_deps\stlport-src\.\stl/_list.h @ 292] 
07 0019fac8 00411174 generals!ControlBar::populatePurchaseScience+0x531 [D:\Projects\TheSuperHackers\GeneralsGameCode\GeneralsMD\Code\GameEngine\Source\GameClient\GUI\ControlBar\ControlBar.cpp @ 266] 
08 0019facc 00740489 generals!MiscAudio::MiscAudio+0x2b4
09 0019fad8 0041122a generals!ConnectionManager::getPacketArrivalCushion+0x29 [D:\Projects\TheSuperHackers\GeneralsGameCode\GeneralsMD\Code\GameEngine\Source\GameNetwork\ConnectionManager.cpp @ 2073] 
0a 0019fb08 00414b56 generals!MiscAudio::`scalar deleting destructor'+0x2a
0b 0019fed4 008e4c52 generals!std::_STLP_alloc_proxy<AudioEventInfo * *,AudioEventInfo *,std::allocator<AudioEventInfo *> >::allocate+0x26 [D:\Projects\TheSuperHackers\GeneralsGameCode\build\vc6\_deps\stlport-src\.\stl/_alloc.h @ 520] 
0c 0019ff70 76c8fcc9 generals!LadderList::checkLadder+0x20a [D:\Projects\TheSuperHackers\GeneralsGameCode\GeneralsMD\Code\GameEngine\Source\GameNetwork\GameSpy\LadderDefs.cpp @ 505] 
0d 0019ff80 77b182ae KERNEL32!BaseThreadInitThunk+0x19
0e 0019ffdc 77b1827e ntdll!__RtlUserThreadStart+0x2f
0f 0019ffec 00000000 ntdll!_RtlUserThreadStart+0x1b

[xezon]

Previous comment hidden. The PDB did not match the Release build, and therefore was garbage. Here is the proper callstack taken with windbg and pristine VS6 build:

(5014.cbc): Access violation - code c0000005 (first chance)
First chance exceptions are reported before any exception handling.
This exception may be expected and handled.
*** WARNING: Unable to verify checksum for C:\Generals\English\Command & Conquer Generals Zero Hour\generals.exe
eax=00000000 ebx=065135c8 ecx=00000000 edx=00a8a3c4 esi=065137e0 edi=065137e0
eip=00514730 esp=0019f934 ebp=00b6a0bc iopl=0         nv up ei pl zr na pe nc
cs=0023  ss=002b  ds=002b  es=002b  fs=0053  gs=002b             efl=00010246
generals!GameWindow::winEnable:
00514730 8b4104          mov     eax,dword ptr [ecx+4] ds:002b:00000004=????????
0:000> k
 # ChildEBP RetAddr  
00 0019f930 005d25e0 generals!GameWindow::winEnable [D:\Projects\TheSuperHackers\GeneralsGameCode\GeneralsMD\Code\GameEngine\Source\GameClient\GUI\GameWindow.cpp @ 641] 
01 0019f960 005d282d generals!ControlBar::populateBuildQueue+0x1f0 [D:\Projects\TheSuperHackers\GeneralsGameCode\GeneralsMD\Code\GameEngine\Source\GameClient\GUI\ControlBar\ControlBarCommand.cpp @ 598] 
02 0019f984 005d238d generals!ControlBar::updateContextCommand+0xad [D:\Projects\TheSuperHackers\GeneralsGameCode\GeneralsMD\Code\GameEngine\Source\GameClient\GUI\ControlBar\ControlBarCommand.cpp @ 753] 
03 0019f9e8 00468ca6 generals!ControlBar::populateCommand+0x50d [D:\Projects\TheSuperHackers\GeneralsGameCode\GeneralsMD\Code\GameEngine\Source\GameClient\GUI\ControlBar\ControlBarCommand.cpp @ 515] 
04 0019fa00 00468052 generals!ControlBar::switchToContext+0x196 [D:\Projects\TheSuperHackers\GeneralsGameCode\GeneralsMD\Code\GameEngine\Source\GameClient\GUI\ControlBar\ControlBar.cpp @ 2221] 
05 0019fa30 00467877 generals!ControlBar::evaluateContextUI+0x3c2 [D:\Projects\TheSuperHackers\GeneralsGameCode\GeneralsMD\Code\GameEngine\Source\GameClient\GUI\ControlBar\ControlBar.cpp @ 1912] 
06 0019fa5c 0052772d generals!ControlBar::update+0x3a7 [D:\Projects\TheSuperHackers\GeneralsGameCode\GeneralsMD\Code\GameEngine\Source\GameClient\GUI\ControlBar\ControlBar.cpp @ 1505] 
07 0019faac 004bf062 generals!InGameUI::update+0x6ed [D:\Projects\TheSuperHackers\GeneralsGameCode\GeneralsMD\Code\GameEngine\Source\GameClient\InGameUI.cpp @ 1847] 
08 0019fac8 00412dd4 generals!GameClient::update+0x512 [D:\Projects\TheSuperHackers\GeneralsGameCode\GeneralsMD\Code\GameEngine\Source\GameClient\GameClient.cpp @ 776] 
09 0019facc 0078af79 generals!GameEngine::update+0x24 [D:\Projects\TheSuperHackers\GeneralsGameCode\GeneralsMD\Code\GameEngine\Source\Common\GameEngine.cpp @ 762] 
0a 0019fb08 00416bf6 generals!Win32GameEngine::update+0x9 [D:\Projects\TheSuperHackers\GeneralsGameCode\GeneralsMD\Code\GameEngineDevice\Source\Win32Device\Common\Win32GameEngine.cpp @ 93] 
0b 0019fb0c 00401d12 generals!GameMain+0x26 [D:\Projects\TheSuperHackers\GeneralsGameCode\GeneralsMD\Code\GameEngine\Source\Common\GameMain.cpp @ 47] 
0c 0019fed4 009add5e generals!WinMain+0x512 [D:\Projects\TheSuperHackers\GeneralsGameCode\GeneralsMD\Code\Main\WinMain.cpp @ 1074] 
0d 0019ff70 76c8fcc9 generals!WinMainCRTStartup+0x134
0e 0019ff80 77b182ae KERNEL32!BaseThreadInitThunk+0x19
0f 0019ffdc 77b1827e ntdll!__RtlUserThreadStart+0x2f
10 0019ffec 00000000 ntdll!_RtlUserThreadStart+0x1b