MilesAudioManager::killLowestPrioritySoundImmediately tries to erase an element with an iterator on an unrelated container

[Mauller]

Area(s) with this issue?

No response

Describe the issue

Miles audio manager attempts to use an iterator to erase a playing 3D sound using an iterator that is out of bounds of the container. Line 2071 - killLowestPrioritySoundImmediately

This could be casued by other memory issues as the pointer is returning 0xDEADBEEF which could be an indication that something has altered memory in an unexpected way and we are going beyond allocated memory.

Steps to reproduce

Run Generals under debug in VS22

Attachments

No response

[Mauller]

This seems to be a similar issue to #464 where pointers are being used and abused in ways that don't work properly.

[xezon]

Demoted from Critical to Minor because this was no concern for the VS6 runtime. It may be a more severe problem with different std::list implementations.