Skip to content

Properly implement transpose between Matrix4 and D3DMatrix #552

Open
@xezon

Description

@xezon

The code uses DirectX functions reinterpret_cast's to convert matrices from row major to column major and vice versa. The DirectX functions need to be replaced, the reinterpret_cast's removed.

Reference change:

TheAssemblyArmada/Thyme@2114738

// When converting Matrix4 to D3DMATRIX or vice versa always use conversion function below.
 
// Reason being, D3DMATRIX is row major matrix, and Matrix4 is column major matrix.
 
// Thus copying from one to another will always require a transpose (or invert).

Metadata

Metadata

Assignees

No one assigned

    Labels

    MajorSeverity: Minor < Major < Critical < BlockerRefactorImproves the structure of the code, with negligible changes in function.

    Type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions