ParticleSystemManager::update is bogus

[xezon]

void ParticleSystemManager::update( void )
{
...
	ParticleSystem *sys;

	for(ParticleSystemListIt it = m_allParticleSystemList.begin(); it != m_allParticleSystemList.end();) 
	{
		sys = (*it);
		if (!sys) {
			continue; // <---- this would cause infinite loop if it were to hit
		}

		if (sys->update(m_localPlayerIndex) == false)
		{
			++it;
			sys->deleteInstance();
		} else {
			++it;
		}
	}
}

[Mauller]

The way the iterators are being handled is just completely wrong too, they should be calling

sys->deleteInstance();
it = m_allParticleSystemList.erase(it);

so this is probably why that silly continue is there when it shouldn't be.

EDIT: Ah i see why now, the particlesystem itself removes itself and the iterator it belonged to from the list within it's destructor.

They make a call to TheParticleSystemManager->friend_removeParticleSystem(this); once they have finished their own cleanup.

[Mauller]

ParticleSystemManager::destroyAttachedSystems seems to be doing similar things too with the way it is handling the m_allParticleSystemList

EDIT: this one is actually fine since the iterator is handled by the for loop and not within the loop body.

[xezon]

If there was a null element in m_allParticleSystemList, then the loop would be infinite.

[Mauller]

If there was a null element in m_allParticleSystemList, then the loop would be infinite.

Ah yes, just noticed it.

These kinds of loops should be while loops anyway if the iterator is being handled within the loop body.