Skip to content

[GEN] Add new key mapping for Select All Aircraft to original game languages #2772

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

xezon
Copy link
Contributor

@xezon xezon commented May 10, 2025

This change adds a new key mapping for Select All Aircraft to the original game languages in Generals.

Select All Aircraft for German is bound to CTRL+Q. Potential key conflicts are not addressed.

TODO

  • Add documentation

@xezon xezon added Enhancement Is an improvement or new feature Minor Severity: Minor < Major < Critical < Blocker labels May 10, 2025
@@ -654,6 +654,17 @@ CommandMap SELECT_ALL
DisplayName = GUI:SelectAll
END

; Patch108p @feature xezon 10/05/2025 Backports new key mapping from Zero Hour.
CommandMap SELECT_ALL_AIRCRAFT
Key = KEY_W

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In French it should be bound to 'Z' because the French use an azerty-keyboard. (The 'select-all' is therefore assigned to 'A' for example)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why?

; Patch108p @feature xezon 10/05/2025 Backports new key mapping from Zero Hour.
; Uses CTRL+Q mapping because W is already mapped by Guard mode.
CommandMap SELECT_ALL_AIRCRAFT
Key = KEY_Q
Copy link

@roossienb roossienb May 10, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Where would the guard button be defined? I think it is a unit-specific command, but I cannot find it in the INI.
Based on the German keyboard layout (qwertz), it does not make sense it is assigned to W and should be changed, rather that assign an illogical key to select all aircraft.

edit: I saw your youtube video and see the issue. I still think we need to change the german key layout to match the keyboard. 'bewachen' could also have hotkey 'b' and still be logical (if 'b' isn't used for something else)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well we open Pandoras box if we try to change keys at mass, because one reassignment will lead to new conflicts.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement Is an improvement or new feature Minor Severity: Minor < Major < Critical < Blocker
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants