Skip to content

Fix missing md extensions and update relative links #40

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

HossamAbubakr
Copy link

@HossamAbubakr HossamAbubakr commented Apr 19, 2025

Hello,

I have noticed that many relative links resulted in a github 404 page, after checking the markdown I noticed the following.

  1. Several links are missing the md extension
  2. Wrong relative links for nested files
  3. Reference to non-exisiting files or files that are in a completely different folder (ex. how to contribute)

This pull request aims to mitigate only 1 and 2.
As I understand that everything is still WIP so 3 makes sense being as is for now.

Thank you

@DevGeniusCode
Copy link
Collaborator

If I remember correctly, the links were intentionally just filenames, to support internal wiki links and avoid opening the link on a new page.

@HossamAbubakr
Copy link
Author

Oh interesting.

May I know what platform are you using as the wiki? As far as I know some systems allow the usage of extra syntax to specify the target.
Ex. {:target="_blank"}

@DevGeniusCode
Copy link
Collaborator

DevGeniusCode commented Apr 21, 2025

This repository is used to manage the content of the project's GitHub built-in wiki.

The wiki pages are version-controlled and stored as Markdown files within this repository.
When changes are merged into the main branch, the GitHub wiki is automatically synchronized with the latest content.

This approach allows for code review, collaboration, and version history of the documentation, while keeping the official GitHub wiki up to date.

You can view the live GitHub wiki here:
GeneralsGameCode Wiki
GeneralsGamePathc Wiki

@HossamAbubakr
Copy link
Author

Oh! I must have missed it somehow.
Over there the links with extensions seem to work fine, in that case would you like me to revert the changes and keep the fixed "Builds" links or close the whole PR?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants