Skip to content

Add delimiter for ECS Changelog summary #1435

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

sravankumar985
Copy link
Contributor

Summary

The Template Changelog summary is not delimited properly.

Ref: https://www.thethingsindustries.com/docs/enterprise/aws/ecs/

Screenshots

Before:

image

After:

image

Changes

Added a delimiter for the template changelog summary.

Notes for Reviewers

None.

Checklist

  • Scope: The referenced issue is addressed, there are no unrelated changes.
  • Run Locally: Verified that the docs build using make server, posted screenshots, verified external links. Test with HUGO_PARAMS_SEARCH_ENABLED=true if style changes will affect the search bar.
  • New Features Marked: Documentation for new features is marked using the new-in-version shortcode, according to the guidelines in CONTRIBUTING.
  • Style Guidelines: Documentation obeys style guidelines in CONTRIBUTING.
  • Commits: Commit messages follow guidelines in CONTRIBUTING, there are no fixup commits left.

@happyRip happyRip changed the title doc : Add delimiter for ECS Changelog summary Add delimiter for ECS Changelog summary Apr 15, 2025
Copy link
Contributor

@KrishnaIyer KrishnaIyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This actually won't work as this entire file gets replaced every time a new release action is run.
This change should be here https://github.com/TheThingsIndustries/lorawan-stack/blob/v3.34/.github/workflows/generate-docs-pr.yml#L87-L93 @happyRip

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants