Skip to content

Add MAC settings profiles UI - #7707

Merged
ryaplots merged 17 commits into
v3.34from
feature/mac-settings-fe
Sep 8, 2025
Merged

Add MAC settings profiles UI#7707
ryaplots merged 17 commits into
v3.34from
feature/mac-settings-fe

Conversation

@ryaplots

@ryaplots ryaplots commented Sep 2, 2025

Copy link
Copy Markdown
Contributor

Summary

References #7594

Changes

  • Add mac settings profiles list
  • Add mac settings profile create
  • Add mac settings profile edit
  • Assign mac settings profile to device
  • Add e2e tests

Testing

Steps
  1. Go to device general settings -> network layer, see mac settings profile field and a button to create profile
  2. Create mac settings profile, clicking the create button should return you to device general settings
  3. Go to mac settings profiles list
  4. Try to edit a profile
  5. Try deleting a profile
  6. Go to any device general settings -> network layer and try to assign mac settings profile
Results
Screenshot 2025-09-02 at 16 19 46 Screenshot 2025-09-02 at 16 20 07 Screenshot 2025-09-02 at 16 20 34

Checklist

  • Scope: The referenced issue is addressed, there are no unrelated changes.
  • Compatibility: The changes are backwards compatible with existing API, storage, configuration and CLI, according to the compatibility commitments in README.md for the chosen target branch.
  • Documentation: Relevant documentation is added or updated.
  • Testing: The steps/process to test this feature are clearly explained including testing for regressions.
  • Infrastructure: If infrastructural changes (e.g., new RPC, configuration) are needed, a separate issue is created in the infrastructural repositories.
  • Changelog: Significant features, behavior changes, deprecations and fixes are added to CHANGELOG.md.
  • Commits: Commit messages follow guidelines in CONTRIBUTING.md, there are no fixup commits left.

@ryaplots ryaplots added this to the v3.35.0 milestone Sep 2, 2025
@ryaplots ryaplots self-assigned this Sep 2, 2025
@ryaplots ryaplots added the ui/web This is related to a web interface label Sep 2, 2025
@ryaplots
ryaplots requested a review from a team as a code owner September 2, 2025 14:21
@ryaplots
ryaplots requested review from PavelJankoski and mjamescompton and removed request for mjamescompton September 2, 2025 14:21

@PavelJankoski PavelJankoski left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job! Just fix the CI errors.

Comment thread pkg/webui/console/components/mac-settings-section/index.js
Comment thread pkg/webui/console/containers/mac-settings-profile-form/form-validation.js Outdated
Comment thread pkg/webui/console/containers/mac-settings-profile-form/index.js Outdated
Comment thread pkg/webui/console/containers/mac-settings-profile-form/index.js
Comment thread pkg/webui/console/containers/mac-settings-profile-form/index.js
Comment thread pkg/webui/console/containers/mac-settings-profile-form/index.js
@ryaplots ryaplots modified the milestones: v3.35.0, v3.34.2 Sep 8, 2025
@ryaplots
ryaplots merged commit 6da0b2e into v3.34 Sep 8, 2025
12 of 13 checks passed
@ryaplots
ryaplots deleted the feature/mac-settings-fe branch September 8, 2025 12:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ui/web This is related to a web interface

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants