Skip to content

Fix flash of LogBackIn modal on load and when logging out - #7710

Merged
ryaplots merged 1 commit into
v3.34from
fix/modal-flash
Sep 5, 2025
Merged

Fix flash of LogBackIn modal on load and when logging out#7710
ryaplots merged 1 commit into
v3.34from
fix/modal-flash

Conversation

@ryaplots

@ryaplots ryaplots commented Sep 4, 2025

Copy link
Copy Markdown
Contributor

Summary

Fix a bug found through PostHog screen recordings:
When first loading, before login, there is a flash of a log back in modal.

Changes

  • Move WithAuth component to wrap sidebar

Notes for Reviewers

There were requests being made before there was a user, there requests would fail because there is no authentication and trigger the lod back in modal. By moving the WithAuth component, these requests won't happen as they will be stopped by this component.

Checklist

  • Scope: The referenced issue is addressed, there are no unrelated changes.
  • Compatibility: The changes are backwards compatible with existing API, storage, configuration and CLI, according to the compatibility commitments in README.md for the chosen target branch.
  • Documentation: Relevant documentation is added or updated.
  • Testing: The steps/process to test this feature are clearly explained including testing for regressions.
  • Infrastructure: If infrastructural changes (e.g., new RPC, configuration) are needed, a separate issue is created in the infrastructural repositories.
  • Changelog: Significant features, behavior changes, deprecations and fixes are added to CHANGELOG.md.
  • Commits: Commit messages follow guidelines in CONTRIBUTING.md, there are no fixup commits left.

@ryaplots ryaplots self-assigned this Sep 4, 2025
@ryaplots
ryaplots requested a review from a team as a code owner September 4, 2025 12:23
@ryaplots ryaplots added the ui/web This is related to a web interface label Sep 4, 2025
@ryaplots
ryaplots merged commit 9346d4e into v3.34 Sep 5, 2025
13 checks passed
@ryaplots
ryaplots deleted the fix/modal-flash branch September 5, 2025 08:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ui/web This is related to a web interface

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants