Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
chore(android): update UI controller according to media3 #3914
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
chore(android): update UI controller according to media3 #3914
Changes from all commits
4f568d3
8c84728
72f5732
bba24b1
7c215c9
5ab02f2
9ab93e3
30d29e8
edbd682
be13ab2
dd33573
9fbca52
e9493a1
9e20777
b44b3ba
2f2edce
777467a
05eb067
c5f8d20
1fbba44
1dba031
1bd4b81
cebc205
d11b8d7
c87d108
f7986a2
f4feae9
e481a23
c207d28
9a40af3
739d6c9
15624e3
6c808fc
73257a2
87d487e
68d617f
d83b866
90ae980
725a5d1
664ebd5
e7ec05a
352cfe9
3b4ab24
652da44
dc155af
4782a31
1cecae9
508c139
6765719
81f929f
299fd70
5acb307
1340da3
8293f1d
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@seyedmostafahasani Can you please start by extracting showSubtitleButton & showSettingButton in a separated PR please ?
I am not sure this PR will me merged unfortunnatly, I am afraid of posssible regressions :/
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for reviewing again.
Yeah, sure.
I will do it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It appears that layout is created but not included in the PlayerView. Am I misread something?