fix(ios): serialize and finish JS license requests - #5071
Open
OskarEichler wants to merge 2 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes
loadedLicenseUrlinstead of overwriting the earlier requestAVContentKeyRequest.processContentKeyResponseErrorthrough the existing error pathPreviously concurrent key requests for the same identifier overwrote one another. JS-reported and invalid-base64 failures also only emitted a React error; AVFoundation never received a terminal response, so the content-key request could remain pending.
Regression coverage
The v6 branch has no test suite (
yarn testreportsno test available), so no FairPlay regression test can be added without a new Apple DRM harness. Verified with:xcrun swiftc -parse ios/Video/Features/DRMManager.swift ios/Video/Features/DRMManager+OnGetLicense.swiftYARN_NODE_LINKER=node-modules yarn buildYARN_NODE_LINKER=node-modules yarn lintgit diff --checkBreaking changes
None.