fix(types): match native manager return values - #5078
Open
OskarEichler wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes
Align the internal
NativeModules.VideoManagerinterface with the actual bridges:void, not promisessaveis optional because Android and Windows do not export itgetCurrentPositionresolves a fractional JavaScript number rather than anInt32Int32The incorrect promise declarations could encourage awaiting values that are actually
undefined, and the integer position type discarded the native APIs' sub-second contract.Regression coverage
The v6 branch has no test suite (
yarn testreportsno test available). Verified with:YARN_NODE_LINKER=node-modules yarn prettier --check src/specs/NativeVideoManager.tsYARN_NODE_LINKER=node-modules yarn buildYARN_NODE_LINKER=node-modules yarn lintgit diff --checkBreaking changes
None for the public
VideoRefAPI; this corrects the package-internal native-module declaration.