draft implementation of include statement and FunctionCall ScadObject#9
draft implementation of include statement and FunctionCall ScadObject#9RustyJoeM wants to merge 1 commit intoTheZoq2:masterfrom
Conversation
|
Sorry for the delay! Overall, it looks like a nice change, though I'm not sure about all the Box and Rc stuff, do you think there is a way to get rid of it? Edit: So github will auto close the corresponding issue. Closes #7 |
|
As i'm not yet professionally experienced in Rust, "architecture"/design review would be definitely welcome :) It is needed to allow different types of items to be in the same vector in my current understanding, but... I'll try to make alternative implementation for this and see if it's cleaner/simpler. Will keep you updated... |
|
Yea, I figured that was the case. Like you said, the builder pattern might look nicer here, something like function
.param(x)
.named_param(name, y)
.build() |
I tried to quickly look into
docs, but the amount felt a bit scary... :) thus no committed usage example.Adding code snippet here, to get a feel on how to use this:
results in following code neing generated: