Skip to content

feat(audio): add C++ realtime DSP core for v0.2.0 - #322

Merged
TheZupZup merged 11 commits into
mainfrom
feature/v0.2.0-cpp-audio-dsp
Aug 7, 2026
Merged

feat(audio): add C++ realtime DSP core for v0.2.0#322
TheZupZup merged 11 commits into
mainfrom
feature/v0.2.0-cpp-audio-dsp

Conversation

@TheZupZup

Copy link
Copy Markdown
Owner

Why C++ here

Linthra already has ReplayGain-style volume normalization in Dart/just_audio, but future EQ/limiting/loudness work needs a realtime-native audio path. This creates a genuine C++ contribution area around DSP rather than adding C++ only for repository language stats.

What ships in this PR

  • new native/linthra_audio C++17 library
  • allocation-free / lock-free mono-stereo processing callback
  • preamp
  • up to 8 parametric peaking-EQ bands
  • stereo-linked peak limiter with immediate attack and smooth release
  • transparent bypass coverage
  • stable C ABI for the future Android/JNI or Dart FFI binding
  • unit tests for bypass, preamp, EQ, limiter stereo linking, and the C ABI
  • 60-second / 48 kHz stereo / 5-band EQ + limiter realtime regression benchmark
  • dedicated CMake CI
  • contributor README describing the realtime constraints

Deliberate safety boundary

This does not silently replace just_audio or alter production playback yet. Inserting PCM processing into the current Android/platform decoder path is a separate integration concern and needs its own review for buffering, audio focus, F-Droid reproducibility, and transparent bypass.

The DSP math and realtime guarantees are therefore established first; the mobile audio-processor bridge can build on a tested core instead of landing everything at once.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 3654059ef2

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread .github/workflows/cpp-audio-dsp.yml
Comment thread native/linthra_audio/src/dsp.cpp

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 86389155ac

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread native/linthra_audio/src/dsp.cpp
Comment thread native/linthra_audio/src/dsp.cpp
@TheZupZup
TheZupZup merged commit abdb90a into main Aug 7, 2026
7 checks passed
@TheZupZup
TheZupZup deleted the feature/v0.2.0-cpp-audio-dsp branch August 7, 2026 15:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant