Skip to content

ci: bump the last checkout pin in ci.yml to v7 (completes #365) - #371

Merged
TheZupZup merged 1 commit into
dependabot/github_actions/github_actions-640176b5abfrom
claude/pr-365-flutter-analyze-qcdv7t
Aug 14, 2026
Merged

ci: bump the last checkout pin in ci.yml to v7 (completes #365)#371
TheZupZup merged 1 commit into
dependabot/github_actions/github_actions-640176b5abfrom
claude/pr-365-flutter-analyze-qcdv7t

Conversation

@TheZupZup

Copy link
Copy Markdown
Owner

Targets #365's branch so the fix lands inside that PR and keeps it self-consistent.

What was actually failing

Not flutter analyze — that step passes on #365's current head (7912ebe):

Analyzing Linthra...
No issues found! (ran in 14.6s)

The Flutter checks job fails one step later, in flutter test:

##[error]3225 tests passed, 1 failed.

The single failure is the pin guardrail, test/tooling/toolchain_pins_test.dart:188
("shared GitHub Actions are pinned consistently → each third-party action is used at
one ref across .github/"):

Expected: an object with length of <1>
  Actual: Set:['v7', 'v5']
   Which: has length of <2>
actions/checkout is pinned to v7 and v5 across .github/workflows/...

Root cause

.github/workflows/ci.yml:102 — the Checkout step of the dependency-guard job —
was still on actions/checkout@v5.

That job did not exist when Dependabot generated the bump (25a5ce8). It was added to
ci.yml later by #370 (75e548a), which introduced two fresh @v5 checkout uses: one
in the new .github/workflows/dart-dependency-updates.yml and one in this new ci.yml
job. Merging main into the Dependabot branch (4150745) brought both onto the PR. The
follow-up commit 7912ebe ("ci: keep checkout pin consistent") fixed the
dart-dependency-updates.yml reference but missed the ci.yml one, so actions/checkout
stayed split across two refs and the guardrail kept failing.

Scope

This is specific to #365, not a pre-existing problem on main. On main all 17
actions/checkout uses are @v5 — one ref, so the guardrail passes there, and CI on
main (a2deeef) is green. The mixed set only exists on the update branch, which is
exactly the drift the guardrail is designed to catch.

Change

One line, .github/workflows/ci.yml:

       - name: Checkout
-        uses: actions/checkout@v5
+        uses: actions/checkout@v7
         with:
           fetch-depth: 0

Every actions/checkout use under .github/ is now @v7, and every other third-party
action resolves to a single ref (setup-java@v5, setup-python@v7, upload-artifact@v7,
download-artifact@v8, flutter-action@v2, rust-toolchain@stable, codex-action@v1).

Not changed

  • No analyzer ignores, no flutter analyze weakening — analyze was already clean.
  • toolchain_pins_test.dart and the other guardrails are untouched; the fix satisfies
    the guardrail rather than relaxing it.
  • flutter-ci-fixer.yml still skips dependabot/* and deps/* branches, in both the
    fix job and the publish-job restatement.
  • No application code touched; ci: bump actions/checkout in / #365 stays a pure actions/checkout v5 → v7 update.

Generated by Claude Code

The dependency-guard job was added to ci.yml after Dependabot generated the
actions/checkout v5 -> v7 bump, so it arrived on this branch via the merge
from main still pinned to @v5. That left actions/checkout split across two
refs, which toolchain_pins_test.dart ("each third-party action is used at one
ref across .github/") fails on.

Same class as the dart-dependency-updates.yml reference fixed earlier — both
new @v5 uses came in with #370. This is the last one; every actions/checkout
use under .github/ is now @v7.
@TheZupZup
TheZupZup marked this pull request as ready for review August 14, 2026 12:41
@TheZupZup
TheZupZup merged commit 250252a into dependabot/github_actions/github_actions-640176b5ab Aug 14, 2026
7 checks passed
@TheZupZup
TheZupZup deleted the claude/pr-365-flutter-analyze-qcdv7t branch August 14, 2026 12:41
TheZupZup added a commit that referenced this pull request Aug 14, 2026
* ci: bump actions/checkout in /

Bumps [actions/checkout](https://github.com/actions/checkout) in `/` from 5 to 7.


Updates `actions/checkout` from 5 to 7
- [Release notes](https://github.com/actions/checkout/releases)
- [Changelog](https://github.com/actions/checkout/blob/main/CHANGELOG.md)
- [Commits](actions/checkout@v5...v7)

---
updated-dependencies:
- dependency-name: actions/checkout
  dependency-version: '7'
  dependency-type: direct:production
  update-type: version-update:semver-major
  dependency-group: github_actions
...

Signed-off-by: dependabot[bot] <support@github.com>

* ci: keep checkout pin consistent

* ci: bump the last checkout pin in ci.yml to v7 (#371)

The dependency-guard job was added to ci.yml after Dependabot generated the
actions/checkout v5 -> v7 bump, so it arrived on this branch via the merge
from main still pinned to @v5. That left actions/checkout split across two
refs, which toolchain_pins_test.dart ("each third-party action is used at one
ref across .github/") fails on.

Same class as the dart-dependency-updates.yml reference fixed earlier — both
new @v5 uses came in with #370. This is the last one; every actions/checkout
use under .github/ is now @v7.

Co-authored-by: Claude <noreply@anthropic.com>

---------

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: TheZupZup <16434778+TheZupZup@users.noreply.github.com>
Co-authored-by: Claude <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants