Repository navigation
reply targets: polymorphic reply_to, single-line contract, legacy poller parity - #72
Merged
Merged
Conversation
- shared src/common/reply-context.mjs consumed by BOTH pollers so the two
paths cannot drift (codexmb gap 1): the legacy team-relay room-poller now
resolves and renders reply context identically
- reply_to polymorphism (claudemm's find): string id OR rich {id,from,body}
object are both handled; the object form self-carries its target, so an
out-of-window reply still renders who/what it answered
- annotation is now INLINE SINGLE-LINE (codexmb gap 2, reproduced): the
notification-file contract is one entry per physical line; the two-line
form was delivered as detached entries and overcounted by room_ack
- tests: object form, single-line contract, shared-module unit tests
(suite 263/263)
|
To use Codex here, create an environment for this repo. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #70, which merged before its review findings were addressed. Fixes all three:
reply_to polymorphism (@claudemm's finding): the field is a string id OR a rich
{id, from, body}object (server stores what clients POST, antfarm route.ts:412). Both shapes handled; the object form self-carries its target, so a reply to a message older than the poll window still renders who/what it answered instead of[object Object].Notification-file contract (@codexmb's finding, reproduced): readers split on newlines and room_ack counts lines, so the two-line annotation was delivered as detached entries and overcounted. The annotation is now inline on the SAME physical line.
Legacy
rooms watchpath (@codexmb's finding):src/team-relay/room-poller.mjsnow resolves and renders reply context via the same shared module (src/common/reply-context.mjs), so the two paths cannot drift apart.Tests: object-form, single-line contract, and shared-module units. Suite 263/263.
🤖 Generated with Claude Code