Skip to content

surface attachments in both poller paths (lost-screenshot lesson) - #74

Merged
ThinkOffApp merged 1 commit into
mainfrom
feat/poller-parity
Aug 28, 2026
Merged

ThinkOffApp merged 1 commit into
mainfrom
feat/poller-parity

Conversation

@ThinkOffApp

Copy link
Copy Markdown
Owner

Step 2 of "no custom hack pollers": fold the MacBook bespoke script's features into the product.

This PR ports attachment surfacing — the 2026-07-19 lesson (a posted screenshot was invisible to a bodies-only extraction and petrus was asked to re-post it). Both message paths now append [IMAGE/AUDIO/FILE ATTACHED: ...] to the body:

  • canonical src/adapters/groupmind.mjs normalize() (unified poller)
  • legacy src/team-relay/room-poller.mjs body build (rooms watch)

Tests for all three kinds + the no-attachment case. Suite 278/278.

Remaining parity items tracked for follow-ups: wake-on-mention hook, 401/403 key hot-reload (legacy rooms watch already has DM polling + command nudge via dm_poller / nudge_mode config).

🤖 Generated with Claude Code

…lesson)

An image/audio/file posted to the room must never be invisible to agents:
petrus posted a screenshot that a bodies-only extraction dropped and was
asked to re-post it. normalize() (canonical adapter) and the legacy
rooms-watch body build now append [IMAGE/AUDIO/FILE ATTACHED: ...] labels,
matching what the MacBook's bespoke script has done since July. Part of
folding that script's features into the product per the no-custom-pollers
rule. Suite 278/278.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 3c21dfcacd

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment on lines +61 to +63
if (msg.image_url) body += ` [IMAGE ATTACHED: ${msg.image_url}]`;
if (msg.audio_url) body += ` [AUDIO ATTACHED: ${msg.audio_url}]`;
if (msg.file_url) body += ` [FILE ATTACHED: ${msg.file_name || msg.file_url}]`;

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Update the GroupMind adapter imported by the CLI

When users run the documented ide-agent-kit platform watch --adapters groupmind path, bin/cli.mjs imports src/team-relay/adapters/groupmind.mjs, not this adapter. That production adapter remains unchanged and its normalize() still discards image_url, audio_url, and file_url, so attachments remain invisible in the unified CLI poller while the new test passes only against an unused duplicate.

Useful? React with 👍 / 👎.

Comment on lines +61 to +63
if (msg.image_url) body += ` [IMAGE ATTACHED: ${msg.image_url}]`;
if (msg.audio_url) body += ` [AUDIO ATTACHED: ${msg.audio_url}]`;
if (msg.file_url) body += ` [FILE ATTACHED: ${msg.file_name || msg.file_url}]`;

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Preserve attachment markers through notification truncation

For any message whose caption is at least 200 characters, these markers are appended after the caption and then removed by formatLine()'s 200-character slice; the legacy poller applies the same slice when constructing its notification line. Since rooms check consumes those notification lines, the attachment is still invisible in precisely that input scenario despite being present in the structured queue.

Useful? React with 👍 / 👎.

@ThinkOffApp
ThinkOffApp merged commit 58b5dac into main Aug 28, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant