Repository navigation
surface attachments in both poller paths (lost-screenshot lesson) - #74
Conversation
…lesson) An image/audio/file posted to the room must never be invisible to agents: petrus posted a screenshot that a bodies-only extraction dropped and was asked to re-post it. normalize() (canonical adapter) and the legacy rooms-watch body build now append [IMAGE/AUDIO/FILE ATTACHED: ...] labels, matching what the MacBook's bespoke script has done since July. Part of folding that script's features into the product per the no-custom-pollers rule. Suite 278/278.
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 3c21dfcacd
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| if (msg.image_url) body += ` [IMAGE ATTACHED: ${msg.image_url}]`; | ||
| if (msg.audio_url) body += ` [AUDIO ATTACHED: ${msg.audio_url}]`; | ||
| if (msg.file_url) body += ` [FILE ATTACHED: ${msg.file_name || msg.file_url}]`; |
There was a problem hiding this comment.
Update the GroupMind adapter imported by the CLI
When users run the documented ide-agent-kit platform watch --adapters groupmind path, bin/cli.mjs imports src/team-relay/adapters/groupmind.mjs, not this adapter. That production adapter remains unchanged and its normalize() still discards image_url, audio_url, and file_url, so attachments remain invisible in the unified CLI poller while the new test passes only against an unused duplicate.
Useful? React with 👍 / 👎.
| if (msg.image_url) body += ` [IMAGE ATTACHED: ${msg.image_url}]`; | ||
| if (msg.audio_url) body += ` [AUDIO ATTACHED: ${msg.audio_url}]`; | ||
| if (msg.file_url) body += ` [FILE ATTACHED: ${msg.file_name || msg.file_url}]`; |
There was a problem hiding this comment.
Preserve attachment markers through notification truncation
For any message whose caption is at least 200 characters, these markers are appended after the caption and then removed by formatLine()'s 200-character slice; the legacy poller applies the same slice when constructing its notification line. Since rooms check consumes those notification lines, the attachment is still invisible in precisely that input scenario despite being present in the structured queue.
Useful? React with 👍 / 👎.
Step 2 of "no custom hack pollers": fold the MacBook bespoke script's features into the product.
This PR ports attachment surfacing — the 2026-07-19 lesson (a posted screenshot was invisible to a bodies-only extraction and petrus was asked to re-post it). Both message paths now append
[IMAGE/AUDIO/FILE ATTACHED: ...]to the body:src/adapters/groupmind.mjsnormalize()(unified poller)src/team-relay/room-poller.mjsbody build (rooms watch)Tests for all three kinds + the no-attachment case. Suite 278/278.
Remaining parity items tracked for follow-ups: wake-on-mention hook, 401/403 key hot-reload (legacy
rooms watchalready has DM polling + command nudge viadm_poller/nudge_modeconfig).🤖 Generated with Claude Code