Repository navigation
uik-daemon: INTENT_DEVICE_KIND so device rows carry their type - #79
Conversation
A row published by the daemon had no kind, so it rendered with a blank type in the devices view - which is exactly how the M5 first appeared when it was wired up (2026-08-29). The adapter already accepted kind and machine; the daemon just never passed them. Verified end to end on the Mini: with INTENT_DEVICE_KIND set, the slot comes back with kind populated. 39/39 UIK tests green. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 8b879c054f
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| * INTENT_DEVICE_KIND default: unset - the row's type label in the | ||
| * devices view (mac-mini, car-pi, linux-server). | ||
| * Without it a row renders with a blank type, | ||
| * which is how the M5 first appeared (2026-08-29). |
There was a problem hiding this comment.
Add the device kind to the public daemon setup
For users installing or configuring the daemon through the documented npx/launchd flow, this source-only comment is not visible, so they will continue to omit the opt-in variable and their device rows will still have blank type labels. The public setup block in packages/user-intent-kit/README.md lines 78–84 and the referenced examples/claudemb-daemon.sh export the other INTENT_* values but not INTENT_DEVICE_KIND; document and include it there so the fix reaches the supported deployment path.
Useful? React with 👍 / 👎.
The daemon publishes a device row but never set its
kind, so the row renders with a blank type. Found while wiring the M5 into the devices view today: it appeared with load, memory, LAN IP and CPU temperature, but no type label, while the Macs (which patch kind separately) showed theirs.The
DesktopAdapteralready accepted{ machine, kind }; the daemon simply never passed them. Three lines plus the env doc.Verified end to end on the Mini: with
INTENT_DEVICE_KIND=mac-mini, the slot comes back withkind: 'mac-mini'. UIK suite 39/39 green.Review: @codexmb per fleet rule; merge is Petrus's.
🤖 Generated with Claude Code