Skip to content

uik-daemon: INTENT_DEVICE_KIND so device rows carry their type - #79

Merged
ThinkOffApp merged 1 commit into
mainfrom
feat/uik-device-kind
Aug 29, 2026
Merged

ThinkOffApp merged 1 commit into
mainfrom
feat/uik-device-kind

Conversation

@ThinkOffApp

Copy link
Copy Markdown
Owner

The daemon publishes a device row but never set its kind, so the row renders with a blank type. Found while wiring the M5 into the devices view today: it appeared with load, memory, LAN IP and CPU temperature, but no type label, while the Macs (which patch kind separately) showed theirs.

The DesktopAdapter already accepted { machine, kind }; the daemon simply never passed them. Three lines plus the env doc.

Verified end to end on the Mini: with INTENT_DEVICE_KIND=mac-mini, the slot comes back with kind: 'mac-mini'. UIK suite 39/39 green.

Review: @codexmb per fleet rule; merge is Petrus's.

🤖 Generated with Claude Code

A row published by the daemon had no kind, so it rendered with a blank
type in the devices view - which is exactly how the M5 first appeared
when it was wired up (2026-08-29). The adapter already accepted kind and
machine; the daemon just never passed them.

Verified end to end on the Mini: with INTENT_DEVICE_KIND set, the slot
comes back with kind populated. 39/39 UIK tests green.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Aug 29, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-08-29T10:16:53.842422Z 8b879c0 Manual request
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 8b879c054f

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment on lines +17 to +20
* INTENT_DEVICE_KIND default: unset - the row's type label in the
* devices view (mac-mini, car-pi, linux-server).
* Without it a row renders with a blank type,
* which is how the M5 first appeared (2026-08-29).

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Add the device kind to the public daemon setup

For users installing or configuring the daemon through the documented npx/launchd flow, this source-only comment is not visible, so they will continue to omit the opt-in variable and their device rows will still have blank type labels. The public setup block in packages/user-intent-kit/README.md lines 78–84 and the referenced examples/claudemb-daemon.sh export the other INTENT_* values but not INTENT_DEVICE_KIND; document and include it there so the fix reaches the supported deployment path.

Useful? React with 👍 / 👎.

@ThinkOffApp
ThinkOffApp merged commit eb37369 into main Aug 29, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant