Skip to content

Let the approval queue shrink: /intents?status= filter - #85

Merged
ThinkOffApp merged 1 commit into
mainfrom
feat/intents-status-filter
Aug 30, 2026
Merged

ThinkOffApp merged 1 commit into
mainfrom
feat/intents-status-filter

Conversation

@ThinkOffApp

Copy link
Copy Markdown
Owner

The queue petrus taps has never been able to shrink. GET /intents ignored query parameters and returned every intent ever created, so decided items sat in the list looking open.

Today that turned into a near-miss. Intent 683c5056 was an echo of a migration fix that had already run. claudeMB spotted it and deliberately did not re-run it — re-running would have pkilled a healthy rsync in the middle of a 156 GB copy. The queue handed him a live grenade because it could not tell him the pin was already pulled.

Change: ?status=pending and ?status=decided filter the list. No parameter behaves exactly as before, so existing callers are untouched. An unknown value returns 400 rather than silently listing everything — a filter that quietly does nothing is precisely how this survived unnoticed.

Verification: new test covers unfiltered, both filters, and the 400. I confirmed it fails against the unpatched source before accepting it. Full suite 289 pass, 0 fail.

This is the server half. The client half — CodeWatch asking for ?status=pending — is @claudemb's, and is what actually makes the list on the phone stop growing.

GET /intents ignored query parameters entirely and returned every intent ever
created. The phone's queue therefore only ever grew, showing decided items
next to open ones, and petrus re-tapped things that had settled hours before.

2026-08-30 made the cost concrete: one such re-tap (683c5056) was an echo of a
migration fix that had already run. claudeMB recognised it and refused - had he
not, re-running it would have pkill'd a healthy rsync in the middle of a 156 GB
copy. The queue handed him a live grenade because it could not tell him the
pin was already pulled.

?status=pending and ?status=decided now filter. No parameter behaves exactly as
before, so every existing caller is unaffected. An unknown value returns 400
rather than silently listing everything - a filter that quietly does nothing is
how this survived this long.

Test covers all three: unfiltered, each filter, and the rejection. Verified it
fails against the unpatched source. Suite 289 pass, 0 fail.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Aug 30, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-08-30T10:47:42.912429Z 5146787 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@ThinkOffApp
ThinkOffApp merged commit be03bec into main Aug 30, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant