Repository navigation
Let the approval queue shrink: /intents?status= filter - #85
Merged
Merged
Conversation
GET /intents ignored query parameters entirely and returned every intent ever created. The phone's queue therefore only ever grew, showing decided items next to open ones, and petrus re-tapped things that had settled hours before. 2026-08-30 made the cost concrete: one such re-tap (683c5056) was an echo of a migration fix that had already run. claudeMB recognised it and refused - had he not, re-running it would have pkill'd a healthy rsync in the middle of a 156 GB copy. The queue handed him a live grenade because it could not tell him the pin was already pulled. ?status=pending and ?status=decided now filter. No parameter behaves exactly as before, so every existing caller is unaffected. An unknown value returns 400 rather than silently listing everything - a filter that quietly does nothing is how this survived this long. Test covers all three: unfiltered, each filter, and the rejection. Verified it fails against the unpatched source. Suite 289 pass, 0 fail. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The queue petrus taps has never been able to shrink.
GET /intentsignored query parameters and returned every intent ever created, so decided items sat in the list looking open.Today that turned into a near-miss. Intent
683c5056was an echo of a migration fix that had already run. claudeMB spotted it and deliberately did not re-run it — re-running would havepkilled a healthy rsync in the middle of a 156 GB copy. The queue handed him a live grenade because it could not tell him the pin was already pulled.Change:
?status=pendingand?status=decidedfilter the list. No parameter behaves exactly as before, so existing callers are untouched. An unknown value returns 400 rather than silently listing everything — a filter that quietly does nothing is precisely how this survived unnoticed.Verification: new test covers unfiltered, both filters, and the 400. I confirmed it fails against the unpatched source before accepting it. Full suite 289 pass, 0 fail.
This is the server half. The client half — CodeWatch asking for
?status=pending— is @claudemb's, and is what actually makes the list on the phone stop growing.