Skip to content

Show columns of other entries on the collection page when some entries fail to parse #1331

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 14, 2024
Merged

Show columns of other entries on the collection page when some entries fail to parse #1331

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/swift-emus-film.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'@keystatic/core': patch
---

Show columns of other entries on the collection page when some entries fail to parse
12 changes: 7 additions & 5 deletions packages/keystatic/src/app/CollectionPage.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -359,8 +359,9 @@ function CollectionTable(
);
const glob = getSlugGlobForCollection(props.config, props.collection);
const rootSchema = { kind: 'object' as const, fields: collection.schema };
return new Map(
entries.map(([slug, dataFile]) => {
const parsedEntries = new Map<string, Record<string, unknown>>();
for (const [slug, dataFile] of entries) {
try {
const { loaded } = loadDataFile(dataFile, formatInfo);
const validated = parseProps(
rootSchema,
Expand Down Expand Up @@ -394,9 +395,10 @@ function CollectionTable(
},
true
);
return [slug, validated as Record<string, unknown>] as const;
})
);
parsedEntries.set(slug, validated as Record<string, unknown>);
} catch {}
}
return parsedEntries;
}, [
collection,
props.config,
Expand Down
Loading