Skip to content

Fix tooltip on list buttons in editor incorrectly showing the keyboard shortcut requiring cmd/ctrl #1402

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 10, 2025
Merged

Fix tooltip on list buttons in editor incorrectly showing the keyboard shortcut requiring cmd/ctrl #1402

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
31f595a
Fix tooltip on list buttons in editor incorrectly showing as the keyb…
emmatown Feb 10, 2025
ff358c6
Fix corepack
emmatown Feb 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions .changeset/empty-cats-yell.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
---
'@keystatic/core': patch
---

Fix tooltip on list buttons in editor incorrectly showing the keyboard
shortcut requiring cmd/ctrl
3 changes: 3 additions & 0 deletions .github/actions/setup-deps/action.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,9 @@ name: 'Setup Dependencies'
runs:
using: 'composite'
steps:
- run: npm install -g [email protected]
shell: bash

- run: corepack enable
shell: bash

Expand Down
2 changes: 1 addition & 1 deletion packages/keystatic/src/form/fields/markdoc/editor/Toolbar.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -706,7 +706,7 @@ function ListButtons() {
</EditorToolbarItem>
<Tooltip>
<Text>{item.label}</Text>
<Kbd meta>{item.shortcut}</Kbd>
<Kbd>{item.shortcut}</Kbd>
</Tooltip>
</TooltipTrigger>
))}
Expand Down