WIP: react-next -> react #28
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emmatown
reviewed
Feb 17, 2021
| { | ||
| "name": "@magical-forms/react", | ||
| "version": "0.2.3", | ||
| "version": "0.3.0", |
There was a problem hiding this comment.
Don't change this. You need a changeset
| }, | ||
| stateFromChange: (changed, current) => { | ||
| if (changed.value === "something") { | ||
| stateFromChange: (current, next) => { |
There was a problem hiding this comment.
It looks like I messed up stateFromChange a bit, it should be the next state as the first arg and the prev state as the second arg. It looks like object stateFromChange is being called with args in the right order but has the wrong names in the types and scalar stateFromChange is called in the wrong order and has the right names for that wrong order(so the names need to be changed too). Could you fix that?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.