Skip to content

Conversation

bluwy
Copy link
Contributor

@bluwy bluwy commented Apr 21, 2025

Upgraded prettier to v3 as a semi-step before updating the rest of the dependencies.

Copy link

changeset-bot bot commented Apr 21, 2025

⚠️ No Changeset found

Latest commit: 06b5f2c

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've moved it to a .prettierrc file so that we don't have to deal with the CJS/ESM stuff if/when we move to it later. Downside is we lose comments though but I'm not sure if it's crucial to keep them.

package.json Outdated
Comment on lines 25 to 27
"resolutions": {
"prettier": "^3.5.3"
},
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added this so that changesets uses prettier v3 instead of its included v2.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changesets should still prioritize the version used by the repo - so removing this should be fine

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm I think you're right, but this does prevent two versions of prettier installed locally

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hm, riiight. We could do this instead:

  1. land this PR sometime this week (I have reviewing it on my TODO list for this week ;p)
  2. release new Changesets v3
  3. switch to that here
  4. remove this line + land this PR :p

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just removed the resolution field for now. I'm not sure we have to block this PR for that. It'd be nice to start making the dependency upgrades soon in this repo.

About that PR, it's not 100% perfect without upstream formatly changes, but I think it's also good enough for the interim if we want to merge that.

@Andarist Andarist merged commit 1443e92 into Thinkmill:main Apr 22, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants