-
Notifications
You must be signed in to change notification settings - Fork 59
Upgrade prettier to v3 #241
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've moved it to a .prettierrc
file so that we don't have to deal with the CJS/ESM stuff if/when we move to it later. Downside is we lose comments though but I'm not sure if it's crucial to keep them.
package.json
Outdated
"resolutions": { | ||
"prettier": "^3.5.3" | ||
}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I added this so that changesets uses prettier v3 instead of its included v2.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changesets should still prioritize the version used by the repo - so removing this should be fine
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm I think you're right, but this does prevent two versions of prettier installed locally
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hm, riiight. We could do this instead:
- land this PR sometime this week (I have reviewing it on my TODO list for this week ;p)
- release new Changesets v3
- switch to that here
- remove this line + land this PR :p
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I just removed the resolution field for now. I'm not sure we have to block this PR for that. It'd be nice to start making the dependency upgrades soon in this repo.
About that PR, it's not 100% perfect without upstream formatly changes, but I think it's also good enough for the interim if we want to merge that.
Upgraded prettier to v3 as a semi-step before updating the rest of the dependencies.